This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix alternate stack cleanup on MUSL #18685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janvorli
added
os-linux
jkotas
reviewed
Jun 28, 2018
src/pal/src/exception/signal.cpp
Outdated
| @@ -199,6 +199,7 @@ Return : | |||
| void FreeSignalAlternateStack() | |||
| { | |||
| stack_t ss, oss; | |||
| ss.ss_size = MINSIGSTKSZ; | |||
There was a problem hiding this comment.
Maybe add a comment that this field is not actually ignored for SS_DISABLE on MUSL?
There was a problem hiding this comment.
That's weird - I have added that comment, I must have forgotten to push that change.
jkotas
approved these changes
Jun 28, 2018
The MUSL implementation of sigaltstack checks that the ss.ss_size is larger or equal than the MINSIGSTKSZ even when the ss_flags is set to SS_DISABLE even though Linux man page for sigaltstack states that when this flag is set, all other ss fields are ignored. We were not setting the ss_size in this case and it was causing a memory leak for each thread that has terminated on MUSL based Linux distros like Alpine. Glibc implementation doesn't check the ss_size when the SS_DISABLE is set so the problem was really MUSL specific.
janvorli
force-pushed
the
fix-musl-sigaltstack-issue
branch
from
a325aa8 to
76ce225
Compare
danmoseley
removed
the
Servicing-consider
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
The MUSL implementation of sigaltstack checks that the ss.ss_size is larger or equal than the MINSIGSTKSZ even when the ss_flags is set to SS_DISABLE even though Linux man page for sigaltstack states that when this flag is set, all other ss fields are ignored. We were not setting the ss_size in this case and it was causing a memory leak for each thread that has terminated on MUSL based Linux distros like Alpine. Glibc implementation doesn't check the ss_size when the SS_DISABLE is set so the problem was really MUSL specific. Commit migrated from dotnet/coreclr@83bdd21
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MUSL implementation of sigaltstack checks that the ss.ss_size is
larger or equal than the MINSIGSTKSZ even when the ss_flags is set
to SS_DISABLE even though Linux man page for sigaltstack states that
when this flag is set, all other ss fields are ignored.
We were not setting the ss_size in this case and it was causing a memory
leak for each thread that has terminated on MUSL based Linux distros
like Alpine.
Glibc implementation doesn't check the ss_size when the SS_DISABLE is set
so the problem was really MUSL specific.