This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[ARM32] Simplify getting aligment value when remorphing #11709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip aligment computation in morphing phase when remorphing It simplify getting alignment value for struct morphed to FIELD_LIST in ARM32/RyuJIT
|
cc/ @dotnet/jit-contrib |
src/jit/morph.cpp
Outdated
| @@ -3207,10 +3207,17 @@ GenTreeCall* Compiler::fgMorphArgs(GenTreeCall* call) | |||
| } | |||
|
|
|||
| // We don't use the "size" return value from InferOpSizeAlign(). | |||
There was a problem hiding this comment.
Seems like this comment ought to remain next to the call to InferOpSizeAlign.
Move comment about `InferOpSizeAlign`
BruceForstall
approved these changes
May 19, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify getting aligment value in morphing phase when remorphing by using argument table.
It can be useful to get alignment value for struct morphed to FIELD_LIST in ARM32/RyuJIT.