Fix cmd exit codes #1028
Fix cmd exit codes #1028
Conversation
The use of goto :eof in numerous places in the build and test scripts is problematic. If preceded by an echo or other command, it will overwrite the exit code and the script may return incorrectly. This was happening for buildtest, masking a recent ycompilation error in one of the tests. Change all of the goto :eof's to exit /b.
mmitche
force-pushed
the
fix-cmd-exit-codes
branch
from
c01164e to
1b52a8e
Compare
|
I think the commits should be split. In addition, why should we remove the tests, if they're valid tests we should fix the failure -- no? |
|
@kangaroo right now the tests are failing to build because the sources are a bit mangled. I have a fix for this in flight. |
|
I'll leave that up to @mmitche. |
|
We should, but I'd like to get a clean run and a real fix could take longer. I'll make sure to file an issue about it. Sent from my Windows Phone From: Geoff Nortonmailto:notifications@github.com I think the commits should be split. In addition, why should we remove the tests, if they're valid tests we should fix the failure -- no? — |
See #1036, #1037 and #1038
mmitche
force-pushed
the
fix-cmd-exit-codes
branch
from
1b52a8e to
c122ee6
Compare
|
@kangaroo @pgavlin I took a look at the failing tests and couldn't see anything obvious straight out. I filed 1036 and 1037 for the runtime failure and kept the separate commits for now. /cc @richardlford |
|
@dotnet-bot test this please |
|
LGTM. Thanks for doing this. |
Fix exit codes in build.cmd/buildtest/cmd/runtest.cmd to report if there is a failure.
Some recently added tests were failing because of this error. I've removed these tests for now. I kept this as a separate commit for the purposes of easy-undo. Let me know if this should be squashed instead.
/cc @pgavlin