Skip to content

Polish release notes 1.x #8357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 10, 2023
Merged

Polish release notes 1.x #8357

merged 8 commits into from
Apr 10, 2023

Conversation

Jay-o-Way
Copy link
Contributor

@Jay-o-Way Jay-o-Way requested review from rbhanda and leecow as code owners April 5, 2023 20:04
@Jay-o-Way
Copy link
Contributor Author

Hold on, i saw some things i have to fix

mairaw
mairaw requested changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a few comments. Didn't duplicate the same comment across all occcurrences.

Jay-o-Way and others added 4 commits April 6, 2023 09:43
@Jay-o-Way @mairaw
escape
578fd4d 
Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
@Jay-o-Way @mairaw
undo
f50c699 
Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
@Jay-o-Way
extras
accb1b3
@Jay-o-Way
Merge branch 'Format-MD-files-1' of https://github.com/Jay-o-Way/core …
8ed6387 
…into Format-MD-files-1
mairaw
mairaw requested changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep commit messages as-is unless display is messed up without the proper formatting.

mairaw and others added 2 commits April 7, 2023 19:13
@mairaw
Merge branch 'main' into Format-MD-files-1
063c448
@Jay-o-Way @mairaw
revert titles
2ab33e6 
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
@Jay-o-Way
Copy link
Contributor Author

PTAL

@mairaw mairaw merged commit 1085350 into dotnet:main Apr 10, 2023
@Jay-o-Way Jay-o-Way deleted the Format-MD-files-1 branch April 10, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mairaw mairaw mairaw approved these changes

@rbhanda rbhanda Awaiting requested review from rbhanda rbhanda is a code owner

@leecow leecow Awaiting requested review from leecow leecow is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jay-o-Way @mairaw