Add GenericHost playground sample #912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keboo
reviewed
May 29, 2020
| <OutputType>Exe</OutputType> | ||
| <TargetFramework>netcoreapp3.1</TargetFramework> | ||
| <GenerateDocumentationFile>true</GenerateDocumentationFile> | ||
| <LangVersion>latest</LangVersion> |
There was a problem hiding this comment.
Since latest will be the latest installed on the running computer, I recommend setting this to 8 to match the other projects.
jonsequitur
reviewed
May 29, 2020
| { | ||
| public class GreeterOptions | ||
| { | ||
| public string Name { get; set; } |
There was a problem hiding this comment.
If this is intended to be called by the model binder, then you don't need the setter.
jonsequitur
approved these changes
May 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking through PRs I found that quite a lot of folks ask for documentation and samples on how to use
System.CommandLine.Hosting. Also, I think it useful to have a playground for Hosting since it allows people to play with it and share user feedback. Therefore this PR.Fixes: #482
Relates: #671, #826, #440