Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion eng/Version.Details.props
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
<?xml version="1.0" encoding="utf-8"?>
<!--
This file is auto-generated by the Maestro dependency flow system.
Do not edit it manually, as it will get overwritten by automation.
Expand Down
2 changes: 1 addition & 1 deletion eng/Version.Details.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<Dependencies>
<Source Uri="https://github.com/dotnet/dotnet" Mapping="command-line-api" Sha="5c3434d8b831745673c31e186906f463e1036301" BarId="279843" />
<Source Uri="https://github.com/dotnet/dotnet" Mapping="command-line-api" Sha="f4b7bd12733f53a99cb8dd2564c77e2e6f10a05d" BarId="284884" />
<ProductDependencies>
</ProductDependencies>
<ToolsetDependencies>
Expand Down
8 changes: 8 additions & 0 deletions es-metadata.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
schemaVersion: 0.0.1
isProduction: true
accountableOwners:
service: 7a9b52f6-7805-416c-9390-343168c0cdb3
routing:
defaultAreaPath:
org: devdiv
path: DevDiv\NET Libraries
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,6 @@ System.CommandLine.Invocation
public abstract class CommandLineAction
public System.Boolean ClearsParseErrors { get; }
public System.Boolean Terminating { get; }
protected System.Void set_Terminating(System.Boolean value)
public class ParseErrorAction : SynchronousCommandLineAction
.ctor()
public System.Boolean ShowHelp { get; set; }
Expand Down
4 changes: 4 additions & 0 deletions src/System.CommandLine.Tests/TestActions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ public SynchronousTestAction(

public override bool ClearsParseErrors { get; }

public override bool Terminating { get; }

public override int Invoke(ParseResult parseResult)
{
_invoke(parseResult);
Expand All @@ -46,6 +48,8 @@ public AsynchronousTestAction(

public override bool ClearsParseErrors { get; }

public override bool Terminating { get; }

public override Task<int> InvokeAsync(ParseResult parseResult, CancellationToken cancellationToken = default)
{
_invoke(parseResult);
Expand Down
3 changes: 2 additions & 1 deletion src/System.CommandLine/EnvironmentVariablesDirective.cs
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,10 @@ private sealed class EnvironmentVariablesDirectiveAction : SynchronousCommandLin
internal EnvironmentVariablesDirectiveAction(EnvironmentVariablesDirective directive)
{
_directive = directive;
Terminating = false;
}

public override bool Terminating => false;

public override int Invoke(ParseResult parseResult)
{
SetEnvVars(parseResult);
Expand Down
2 changes: 1 addition & 1 deletion src/System.CommandLine/Invocation/CommandLineAction.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ private protected CommandLineAction()
/// <summary>
/// Indicates that the action terminates a command line invocation, and later actions are skipped.
/// </summary>
public bool Terminating { get; protected init; } = true;
public virtual bool Terminating => true;

/// <summary>
/// Indicates that the action clears any parse errors associated with symbols other than one that owns the <see cref="CommandLineAction"/>.
Expand Down