Skip to content

Update test projects to use "net8.0" as a moniker for testing #2566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 19, 2025
Merged

Update test projects to use "net8.0" as a moniker for testing #2566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
92a8a42
Bumped up to LTS version, .NET 8.0
zbalkan Jun 5, 2025
4fbed1e
Bumped up dependencies
zbalkan Jun 5, 2025
1645b71
Rolled back dependency versions to 8
zbalkan Jun 5, 2025
ffea4e6
Rolled back NET8_0_OR_GREATER
zbalkan Jun 5, 2025
94fd62f
Fixed newline issue
zbalkan Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,18 +20,18 @@
<!-- external dependencies -->
<PackageVersion Include="ApprovalTests" Version="7.0.0-beta.3" />
<PackageVersion Include="BenchmarkDotNet" Version="0.13.1" />
<PackageVersion Include="AwesomeAssertions" Version="8.0.2" />
<PackageVersion Include="AwesomeAssertions" Version="8.1.0" />
<PackageVersion Include="Microsoft.CSharp" Version="4.7.0" />
<PackageVersion Include="Microsoft.DotNet.PlatformAbstractions" Version="3.1.6" />
<PackageVersion Include="Newtonsoft.Json" Version="13.0.2" />
<PackageVersion Include="System.Memory" Version="4.5.4" />
<PackageVersion Include="system.reactive.core" Version="5.0.0" />
<PackageVersion Include="Newtonsoft.Json" Version="13.0.3" />
<PackageVersion Include="System.Memory" Version="4.6.3" />
<PackageVersion Include="system.reactive.core" Version="6.0.0" />
</ItemGroup>

<ItemGroup Condition="'$(DisableArcade)' == '1'">
<!-- The xunit version should be kept in sync with the one that Arcade promotes -->
<PackageVersion Include="xunit" Version="2.4.2" />
<PackageVersion Include="xunit.runner.visualstudio" Version="2.4.3" />
</ItemGroup>
</Project>

</Project>
8 changes: 4 additions & 4 deletions src/System.CommandLine.Tests/CompletionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -784,12 +784,12 @@ public void When_parsing_from_text_if_the_proximate_option_is_completed_then_com
{
var command = new RootCommand
{
CreateOptionWithAcceptOnlyFromAmong(name: "--framework", "net7.0"),
CreateOptionWithAcceptOnlyFromAmong(name: "--framework", "net8.0"),
CreateOptionWithAcceptOnlyFromAmong(name: "--language", "C#"),
new Option<string>("--langVersion")
};
var configuration = new CommandLineConfiguration(command);
var completions = command.Parse("--framework net7.0 --l", configuration).GetCompletions();
var completions = command.Parse("--framework net8.0 --l", configuration).GetCompletions();

completions.Select(item => item.Label)
.Should()
Expand All @@ -801,12 +801,12 @@ public void When_parsing_from_array_if_the_proximate_option_is_completed_then_co
{
var command = new RootCommand
{
CreateOptionWithAcceptOnlyFromAmong(name: "--framework", "net7.0"),
CreateOptionWithAcceptOnlyFromAmong(name: "--framework", "net8.0"),
CreateOptionWithAcceptOnlyFromAmong(name: "--language", "C#"),
new Option<string>("--langVersion")
};
var configuration = new CommandLineConfiguration(command);
var completions = command.Parse(new[]{"--framework","net7.0","--l"}, configuration).GetCompletions();
var completions = command.Parse(new[]{"--framework","net8.0","--l"}, configuration).GetCompletions();

completions.Select(item => item.Label)
.Should()
Expand Down
Loading