Skip to content

add SetAction overloads returning int and Task<int> #2121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 28, 2023

Conversation

jonsequitur
Copy link
Contributor

Fixes #2109.

@jonsequitur jonsequitur requested a review from adamsitnik March 28, 2023 00:42
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @jonsequitur !

@@ -14,7 +14,7 @@ namespace System.CommandLine.Tests.Invocation
public class InvocationExtensionsTests
{
[Fact]
public async Task Command_InvokeAsync_uses_default_pipeline_by_default()
public async Task Command_InvokeAsync_enables_help_by_default()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for updating the test names 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SetAction will accept a Func<InvocationContext, CancellationToken, Task<int>> callback and not observe the returned exit code.
3 participants