fix #1199 #1342
Merged
fix #1199 #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoslund
approved these changes
Jul 6, 2021
Keboo
approved these changes
Jul 6, 2021
| ParameterType = parameterType; | ||
| } | ||
|
|
||
| public string CommandLine { get; } | ||
| private BindingTestCase( |
There was a problem hiding this comment.
Rather than duplicating the assignments, should the public ctor just invoke this one?
There was a problem hiding this comment.
I changed it so that one constructor calls the other. Neither is public, forcing the use of the factory method which is generic and allows for strongly-typed assertions.
Keboo
approved these changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1199.