Add InvocationContext.GetHost extension method #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a test that illustrates and verifies the use case? |
|
@jonsequitur Test added |
|
@fredrikhr Could you rebase this onto |
jonsequitur
approved these changes
Mar 27, 2021
|
@jonsequitur done, ready for merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an extension method
GetHosttoInvocationContext, so that Command-line Middleware that runs after a call toUseHost()can access the createdIHostinstance easily.It does technically not depend on using
UseHost()since it simply news up aModelBinder<IHost>and passes the InvocationBindingContextto it. Therefore, anyone addingIHostto the BindingContext service provider will be able to use this extension to access theirIHost.fixes #974
ref.: #974 (comment)