Explicit parameter binding #1009
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #952 |
jonsequitur
reviewed
Aug 5, 2020
Comment on lines
213
to
217
| if (parameterDescriptor.HasDefaultValue) | ||
| boundValue = BoundValue.DefaultForValueDescriptor(parameterDescriptor); | ||
| else if (parameterDescriptor.AllowsNull && | ||
| else if (parameterDescriptor.AllowsNull && | ||
| ShouldPassNullToConstructor(constructorDescriptor.Parent, constructorDescriptor)) | ||
| boundValue = BoundValue.DefaultForType(valueDescriptor); |
There was a problem hiding this comment.
It looks like this block should also be part of the extracted GetBoundValue method.
jonsequitur
reviewed
Aug 5, 2020
| // check for nulls | ||
| if (!(handler is ModelBindingCommandHandler bindingHandler)) | ||
| { | ||
| throw new InvalidOperationException("Cannot bind to this type of handler"); |
There was a problem hiding this comment.
Maybe we should just make ModelBindingCommandHandler public?
jonsequitur
approved these changes
Aug 6, 2020
jonsequitur
approved these changes
Aug 6, 2020
|
Replaced with #1018 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows differently named parameters and paired options/arguments