Skip to content

Internal property HelpBuilder.OnCustomize is always null #2116

Closed
@KalleOlaviNiemitalo

Description

@KalleOlaviNiemitalo

As of System.CommandLine 2.0.0-beta4.23172.1 aka commit 0403596, the internal Action<HelpContext>? OnCustomize { get; set; } property still exists and is read, but its value is always null as nothing ever sets it. #2102 deleted the CommandLineBuilder.UseHelp(Action<HelpContext> customize, int? maxWidth = null) method, through which applications were previously able to set the property.

$ git grep -w -e OnCustomize
src/System.CommandLine/Help/HelpBuilder.cs:            if (OnCustomize is {})
src/System.CommandLine/Help/HelpBuilder.cs:                OnCustomize(context);
src/System.CommandLine/Help/HelpBuilder.cs:        internal Action<HelpContext>? OnCustomize { get; set; }

The property and its uses should be deleted, unless a similar customization method is going to be reinstated.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions