Skip to content
This repository was archived by the owner on Apr 20, 2023. It is now read-only.

Update CoreSetup to preview1-25719-04 (master) - #7606

Merged
eerhardt merged 1 commit into
dotnet:masterfrom
dotnet-bot:master-UpdateDependencies
Sep 20, 2017
Merged

Update CoreSetup to preview1-25719-04 (master)#7606
eerhardt merged 1 commit into
dotnet:masterfrom
dotnet-bot:master-UpdateDependencies

Conversation

@dotnet-bot

@dotnet-bot dotnet-bot commented Sep 7, 2017 •
edited
Loading

Copy link
Copy Markdown

/cc @dotnet/dotnet-cli

@eerhardt

eerhardt commented Sep 7, 2017

Copy link
Copy Markdown
Member

/cc @ahsonkhan

@eerhardt

eerhardt commented Sep 7, 2017

Copy link
Copy Markdown
Member

FYI - @dotnet/dotnet-cli update-dependencies seems to be working again in master.

@eerhardt eerhardt mentioned this pull request Sep 7, 2017
Merged
@ahsonkhan

ahsonkhan commented Sep 7, 2017

Copy link
Copy Markdown

@eerhardt, awesome. Tyvm for the update!

@livarcocc

livarcocc commented Sep 7, 2017

Copy link
Copy Markdown

@KevinRansom the failing tests are all F#, can you take a first look at this?

@dotnet-bot dotnet-bot changed the title Update CoreSetup to preview2-25706-02 (master) Update CoreSetup to preview2-25707-01 (master) Sep 7, 2017
@dotnet-bot
dotnet-bot force-pushed the master-UpdateDependencies branch from 5f395b1 to f6cabc8 Compare September 7, 2017 18:38
@KevinRansom

KevinRansom commented Sep 7, 2017

Copy link
Copy Markdown

@livarcocc @eerhardt on it.

@dotnet-bot dotnet-bot changed the title Update CoreSetup to preview2-25707-01 (master) Update CoreSetup to preview2-25707-02 (master) Sep 7, 2017
@dotnet-bot
dotnet-bot force-pushed the master-UpdateDependencies branch from f6cabc8 to 1a29c17 Compare September 7, 2017 22:39
@dotnet-bot dotnet-bot changed the title Update CoreSetup to preview2-25707-02 (master) Update CoreSetup to preview2-25708-01 (master) Sep 8, 2017
@dotnet-bot
dotnet-bot force-pushed the master-UpdateDependencies branch from 1a29c17 to 0c3d356 Compare September 8, 2017 17:37
@dotnet-bot dotnet-bot changed the title Update CoreSetup to preview2-25708-01 (master) Update CoreSetup to preview2-25708-02 (master) Sep 8, 2017
@dotnet-bot
dotnet-bot force-pushed the master-UpdateDependencies branch from 0c3d356 to 55df479 Compare September 8, 2017 22:38
@dotnet-bot dotnet-bot changed the title Update CoreSetup to preview2-25708-02 (master) Update CoreSetup to preview2-25709-01 (master) Sep 9, 2017
@dotnet-bot
dotnet-bot force-pushed the master-UpdateDependencies branch from 55df479 to fd03e1b Compare September 9, 2017 17:28
@dotnet-bot dotnet-bot changed the title Update CoreSetup to preview2-25709-01 (master) Update CoreSetup to preview2-25709-02 (master) Sep 9, 2017
@dotnet-bot
dotnet-bot force-pushed the master-UpdateDependencies branch from fd03e1b to 5da64ee Compare September 9, 2017 21:23
@dotnet-bot dotnet-bot changed the title Update CoreSetup to preview2-25709-02 (master) Update CoreSetup to preview2-25710-01 (master) Sep 10, 2017
@dotnet-bot
dotnet-bot force-pushed the master-UpdateDependencies branch from 5da64ee to 1e63e8f Compare September 10, 2017 17:35
@dotnet-bot dotnet-bot changed the title Update CoreSetup to preview2-25710-01 (master) Update CoreSetup to preview2-25710-02 (master) Sep 10, 2017
@dotnet-bot
dotnet-bot force-pushed the master-UpdateDependencies branch from 1e63e8f to 5b147d1 Compare September 10, 2017 21:55
@eerhardt

eerhardt commented Sep 11, 2017

Copy link
Copy Markdown
Member

@KevinRansom - any update?

@dotnet-bot dotnet-bot changed the title Update CoreSetup to preview2-25710-02 (master) Update CoreSetup to preview2-25711-01 (master) Sep 11, 2017
@dotnet-bot
dotnet-bot force-pushed the master-UpdateDependencies branch from 5b147d1 to a44abef Compare September 11, 2017 17:51
@dotnet-bot dotnet-bot changed the title Update CoreSetup to preview2-25711-01 (master) Update CoreSetup to preview1-25711-02 (master) Sep 11, 2017
@dotnet-bot
dotnet-bot force-pushed the master-UpdateDependencies branch from a44abef to 872bff2 Compare September 11, 2017 23:37
@ahsonkhan

ahsonkhan commented Sep 12, 2017

Copy link
Copy Markdown

@eerhardt, @KevinRansom, any eta on this update?

@janvorli

janvorli commented Sep 12, 2017

Copy link
Copy Markdown
Member

I've tried to do the binary search and the problem came in between:
2.1.0-preview2-25625-01 - commit #dc2ffcdff2fb19e4b252cec3bc6672400a375c1e
2.1.0-preview2-25625-02 - commit #41a2b788cb77668d397e372df40c5215bf61bfa7

But it doesn't change anything in my and @briansull's lists on the gist, since as you can see, the 2.1.0-preview2-25625-01 and the previously known last good 2.1.0-preview2-25616-02 were both built from the same commit.

@eerhardt

eerhardt commented Sep 12, 2017

Copy link
Copy Markdown
Member

Using 2.1.0-preview2-25625-01 I captured the disassembly for the loop that I captured above. You can compare it against the brokenDisassembly.txt link above.

Here is the working disassembly from the previous build:

previousWorksDisassembly.txt

@KevinRansom

KevinRansom commented Sep 12, 2017

Copy link
Copy Markdown

Adding @dsyme

@dotnet-bot dotnet-bot changed the title Update CoreSetup to preview1-25711-02 (master) Update CoreSetup to preview1-25712-01 (master) Sep 12, 2017
@dotnet-bot
dotnet-bot force-pushed the master-UpdateDependencies branch from 872bff2 to e2ae0bd Compare September 12, 2017 18:00
@dotnet-bot dotnet-bot changed the title Update CoreSetup to preview1-25712-01 (master) Update CoreSetup to preview1-25712-02 (master) Sep 12, 2017
@dotnet-bot
dotnet-bot force-pushed the master-UpdateDependencies branch from e2ae0bd to 757bd7f Compare September 12, 2017 21:54
@dotnet-bot dotnet-bot changed the title Update CoreSetup to preview1-25712-02 (master) Update CoreSetup to preview1-25713-01 (master) Sep 13, 2017
@dotnet-bot
dotnet-bot force-pushed the master-UpdateDependencies branch from 757bd7f to 550b42a Compare September 13, 2017 18:17
@JosephTremoulet

JosephTremoulet commented Sep 13, 2017

Copy link
Copy Markdown

PR for JIT fix into CoreCLR is up at dotnet/coreclr#13957.

@dotnet-bot dotnet-bot changed the title Update CoreSetup to preview1-25713-01 (master) Update CoreSetup to preview1-25714-02 (master) Sep 14, 2017
@dotnet-bot
dotnet-bot force-pushed the master-UpdateDependencies branch from 550b42a to a0e0c0c Compare September 14, 2017 22:39
@ahsonkhan

ahsonkhan commented Sep 15, 2017

Copy link
Copy Markdown

Does <CLI_SharedFrameworkVersion>2.1.0-preview1-25714-02</CLI_SharedFrameworkVersion> have @JosephTremoulet's JIT fix? F# tests are still failing.

@eerhardt

eerhardt commented Sep 15, 2017

Copy link
Copy Markdown
Member

No it doesn't.
We just got a CoreCLR build out with @JosephTremoulet's change an hour ago. I just merged that into core-setup dotnet/core-setup#3222.

So the next build of core-setup should have the fix.

@janvorli

janvorli commented Sep 15, 2017

Copy link
Copy Markdown
Member

All Unix builds are segfaulting in crossgen with the latest coresetup version. I've reproed it locally and it seems to be a codegen issue - see https://github.com/dotnet/coreclr/issues/13942

@dotnet-bot dotnet-bot changed the title Update CoreSetup to preview1-25714-02 (master) Update CoreSetup to preview1-25717-01 (master) Sep 17, 2017
@dotnet-bot
dotnet-bot force-pushed the master-UpdateDependencies branch from a0e0c0c to 7d8adb6 Compare September 17, 2017 17:33
@dotnet-bot dotnet-bot changed the title Update CoreSetup to preview1-25717-01 (master) Update CoreSetup to preview1-25717-02 (master) Sep 17, 2017
@dotnet-bot
dotnet-bot force-pushed the master-UpdateDependencies branch from 7d8adb6 to 51a9a2a Compare September 17, 2017 21:52
@livarcocc

livarcocc commented Sep 19, 2017

Copy link
Copy Markdown

@eerhardt @janvorli any updates on this?

@eerhardt

eerhardt commented Sep 19, 2017

Copy link
Copy Markdown
Member

Official builds have been broken for all dotnet/core* repos since yesterday. No way of getting a new core-setup build out right now. The current one has been running for 85 minutes and appears to be hung.

@eerhardt

eerhardt commented Sep 19, 2017

Copy link
Copy Markdown
Member

But once the official builds are unblocked, I believed that last remaining blocking fix is in core-setup.

@dotnet-bot dotnet-bot changed the title Update CoreSetup to preview1-25717-02 (master) Update CoreSetup to preview1-25719-04 (master) Sep 20, 2017
@dotnet-bot
dotnet-bot force-pushed the master-UpdateDependencies branch from 51a9a2a to 7287790 Compare September 20, 2017 00:14
@ahsonkhan

ahsonkhan commented Sep 20, 2017 •
edited
Loading

Copy link
Copy Markdown

But once the official builds are unblocked, I believed that last remaining blocking fix is in core-setup.

Builds are unblocked & CI is green. Can we merge the PR?

@eerhardt
eerhardt merged commit f3932fa into dotnet:master Sep 20, 2017
@eerhardt
eerhardt deleted the master-UpdateDependencies branch September 20, 2017 12:30
@eerhardt eerhardt mentioned this pull request Sep 27, 2017
Closed
@eerhardt eerhardt mentioned this pull request Jan 31, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@nguerrera nguerrera nguerrera approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.