Skip to content
This repository was archived by the owner on Apr 20, 2023. It is now read-only.

Prime cache for deb "installer" #6480

Merged
merged 2 commits into from
May 3, 2017
Merged

Prime cache for deb "installer" #6480

merged 2 commits into from
May 3, 2017

Conversation

@wli3
Copy link

@wli3 wli3 commented May 2, 2017 •
edited
Loading

image

#6370

@wli3 wli3 force-pushed the prime-cache-deb3 branch from 20d553b to b72d338 Compare May 2, 2017 01:00
@wli3
Copy link
Author

wli3 commented May 2, 2017

@bleroy

@wli3
Copy link
Author

wli3 commented May 2, 2017

@dotnet-bot Test RHEL7.2 x64 Release Build

eerhardt
eerhardt reviewed May 2, 2017
View reviewed changes
packaging/deb/postinst Outdated
# Run 'dotnet new' to trigger the first time experience to initialize the cache
echo ."NET Core Tools Telemetry
The .NET Core Tools include a telemetry feature (https://github.com/dotnet/cli/pull/2145) that collects usage information. It’s important that the .NET Team understands how the tools are being used so that we can improve them.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

eerhardt
eerhardt reviewed May 2, 2017
View reviewed changes
build/package/Installer.DEB.targets Outdated
<Project ToolsVersion="14.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Target Name="SetupDebProps"
DependsOnTargets="Init">
DependsOnTargets="Init">

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

nguerrera
nguerrera previously requested changes May 2, 2017
View reviewed changes
Copy link
Contributor

@nguerrera nguerrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR link concerns me

@wli3 wli3 force-pushed the prime-cache-deb3 branch 2 times, most recently from 7f70ac2 to 81d5bb2 Compare May 2, 2017 17:25
@nguerrera nguerrera dismissed their stale review May 2, 2017 18:29

Feedback no longer relevant, but haven't reviewed the rest.

@wli3 wli3 force-pushed the prime-cache-deb3 branch 4 times, most recently from 33742ec to f56c385 Compare May 2, 2017 22:20
@livarcocc livarcocc added this to the 2.0.0 milestone May 2, 2017
@livarcocc
Copy link

livarcocc commented May 2, 2017

@ManishJayaswal @Pilchie for approval.

nguerrera
nguerrera reviewed May 2, 2017
View reviewed changes
build/package/Installer.DEB.proj
BuildSdkDeb;
TestSdkDeb;"
Condition=" '$(OSName)' == 'ubuntu' "
Condition=" '$(OSName)' == 'ubuntu' "

This comment was marked as spam.

Sign in to view

@wli3 wli3 force-pushed the prime-cache-deb3 branch from f56c385 to f630442 Compare May 3, 2017 00:54
@Pilchie
Copy link
Member

Pilchie commented May 3, 2017

What is the customer scenario here? Should this have an ask mode template?

@wli3
Copy link
Author

wli3 commented May 3, 2017

Customer scenario

In the last step of customer installing CLI debain package, sudo dpkg -i dotnet-sdk-VERSION , the installer should invoke a CLI command to trigger the first run experience. It will extract the NuGet cache to local machine. This is important for Visual Studio. The Windows and macOS counterpart has been checked in, this is for Linux Ubuntu/Debian distro.

The same time the telemetry message should be shown in the installer, because the user won't get it in the first run.

Bugs this fixes

CLI #6370

Workarounds, if any

N/A

Risk

The user needs to wait for NuGet cache to be extracted at the first time CLI is invoked.

There is no feature parity between Windows and Ubuntu

Performance impact

N/A

Root cause analysis

N/A

How was the bug found?

N/A

@wli3 wli3 changed the title Prime cache for deb "installer" [Hold before verify] Prime cache for deb "installer" May 3, 2017
@livarcocc
Copy link

livarcocc commented May 3, 2017

@dotnet-bot Test Ubuntu x64 Release Build

@wli3 wli3 force-pushed the prime-cache-deb3 branch from 4e957de to 157ee13 Compare May 3, 2017 18:39
@wli3
Copy link
Author

wli3 commented May 3, 2017 •
edited
Loading

The first commit does have the same problem with #6500

Add the second commit fixed it 157ee13
@livarcocc

@wli3 wli3 changed the title [Hold before verify] Prime cache for deb "installer" Prime cache for deb "installer" May 3, 2017
William Li added 2 commits May 3, 2017 19:59
Run dotnet new after install to prime cache for deb
dbc4c4c 
Copy postinst to correct directory

Can only rely on env for get dotnet command

Print telemetry notice anyway
Run as user instead of root for dotnet new
49f2734
@wli3 wli3 force-pushed the prime-cache-deb3 branch from 157ee13 to 49f2734 Compare May 3, 2017 19:59
@wli3 wli3 merged commit fa9c4ef into dotnet:release/2.0.0 May 3, 2017
@omajid
Copy link
Member

omajid commented May 25, 2017 •
edited
Loading

Sorry for jumping in here very late. I suppose this same patch (or a derivative) will apply to RPMs too. I have a few questions:

This is important for Visual Studio.

Can you elaborate? Visual Studio doesn't work on Linux so this can't possibly impact Visual Studio, can it?

The same time the telemetry message should be shown in the installer

If this is a non-interactive installation, messages from the package install may not be shown to the user. And since the first run cache exists on subsequent runs, the message is never shown again.

The dotnet new invocation is a surprising implementation step that works differently under different scenarios:

  • If there are 2 (normal) users on machine, only one gets the cache when .NET Core is installed.
  • If root installed packages (no sudo used in installation, possibly via some GUI software center) root gets nuget cache, no one else does.

Packages touching a user's files (in this case under /home/$SUDO_USER) is generally a no-no: https://stackoverflow.com/questions/3140886/debian-packaging-deploying-files-to-the-user-home-directory

@wli3 wli3 deleted the prime-cache-deb3 branch June 8, 2017 22:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dsplaisted dsplaisted Awaiting requested review from dsplaisted

@johnbeisner johnbeisner Awaiting requested review from johnbeisner

3 more reviewers

@eerhardt eerhardt eerhardt left review comments

@nguerrera nguerrera nguerrera approved these changes

@livarcocc livarcocc livarcocc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Approved to merge Pending Shiproom Approval

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

8 participants

@wli3 @livarcocc @Pilchie @omajid @nguerrera @eerhardt @ManishJayaswal @dnfclas