This repository was archived by the owner on Feb 25, 2021. It is now read-only.
Ignore non-public setters in analyzer #1702
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es with ParameterAttribute
Currently if you have a property like:
```
[Parameter] public string Foo { get; private set; }
```
The analzyer emits a warning about public properties with a `[Parameter]` attribute specified. Since the reason for this warning is about calling the setter (and mutating state at improper points in the rendering cycle) explicit non-public setters should be ignored.
See https://github.com/aspnet/Blazor/issues/1388#issuecomment-439650736 for more elaboration
|
|
|
Any thoughts on the failure? It passes locally for me and doesn't seem at all related to my changes. Flaky? |
|
Thanks for this! It's now moved to dotnet/aspnetcore#4594. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you have a property like:
The analzyer emits a warning about public properties with a
[Parameter]attribute specified. Since the reason for this warning is about calling the setter (and mutating state at improper points in the rendering cycle) explicit non-public setters should be ignored.See https://github.com/aspnet/Blazor/issues/1388#issuecomment-439650736 for more elaboration