partial revert "Flow ANCM version number in the build output (#9269)" #9477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 01b0c88.
jkotalik
approved these changes
Apr 17, 2019
natemcmaster
changed the title
JunTaoLuo
approved these changes
Apr 17, 2019
dougbu
approved these changes
Apr 17, 2019
|
I don't think it conflicts at all with that change. Those were for local reasons only. I don't have a full understanding of what version of VS we are using on CI. I know we tried to roll forward to RTM, and are maybe back to a preview now, but the behavior we see on CI is different than what we see locally. I don't see this repro locally. |
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts commit 01b0c88. Sometime between the successful PR check for #9269 (Apr. 11) and today when the PR was merged, something started causing consistent build failures for ANCM Windows installers.
FYI @aspnet/build - going to merge as soon as this PR check is green.