Update KoreBuild + SDK #9033

pranavkm · 2019-04-03T16:02:12Z

No description provided.

dougbu

global.json should also change to match the underlying SDK

pranavkm · 2019-04-06T01:14:08Z

@dougbu does this look familiar:

F:\workspace\_work\1\s\build\repo.targets(138,5): error MSB4018: The "RepoTasks.RemoveSharedFrameworkDependencies" task failed unexpectedly. [F:\workspace\_work\1\s\.dotnet\buildtools\korebuild\3.0.0-build-20190405.1\KoreBuild.proj]
F:\workspace\_work\1\s\build\repo.targets(138,5): error MSB4018: System.InvalidOperationException: The element 'metadata' in namespace 'http://schemas.microsoft.com/packaging/2013/05/nuspec.xsd' has invalid child element 'frameworkReferences' in namespace 'http://schemas.microsoft.com/packaging/2013/05/nuspec.xsd'. List of possible elements expected: 'packageTypes, releaseNotes, frameworkAssemblies, title, language, developmentDependency, contentFiles, references, summary, license' in namespace 'http://schemas.microsoft.com/packaging/2013/05/nuspec.xsd'. This validation error occurred in a 'frameworkReferences' element. [F:\workspace\_work\1\s\.dotnet\buildtools\korebuild\3.0.0-build-20190405.1\KoreBuild.proj]
F:\workspace\_work\1\s\build\repo.targets(138,5): error MSB4018:    at NuGet.Packaging.Manifest.<>c.<ValidateManifestSchema>b__20_0(Object sender, ValidationEventArgs e) [F:\workspace\_work\1\s\.dotnet\buildtools\korebuild\3.0.0-build-20190405.1\KoreBuild.proj]
F:\workspace\_work\1\s\build\repo.targets(138,5): error MSB4018:    at System.Xml.Schema.XNodeValidator.ValidationCallback(Object sender, ValidationEventArgs e) [F:\workspace\_work\1\s\.dotnet\buildtools\korebuild\3.0.0-build-20190405.1\KoreBuild.proj]

dougbu · 2019-04-06T01:21:08Z

@pranavkm I don't recall seeing that error before. Is it already described in an AspNetCore or AspNetCore-Internal issue?

@JunTaoLuo do you have an inkling what's going wrong w/ that SharedFx task?

JunTaoLuo · 2019-04-06T01:48:00Z

Hmm not sure. Though I'm wondering if it's related to NuGet/Home#7342? It's a new feature that just got merged so maybe we need a new version of NuGet?

dougbu · 2019-04-06T01:51:48Z

Hmm, maybe but only if NuGet made a breaking change while adding the new NuGet/Home#7342 feature.

pranavkm · 2019-04-08T17:41:27Z

cc @natemcmaster

Bumping up NuGet.Build.Tasks to 5.0.0 didn't help. frameworkReferences is a fairly new feature, do we need to reference a preview build of NuGet in repo-tasks?

JunTaoLuo · 2019-04-08T18:22:33Z

cc @rrelyea @nkolev92? Can you comment on the NuGet requirements for frameworkReferences support?

natemcmaster · 2019-04-08T18:53:37Z

Which package is being processed when the error about frameworkReferences is thrown? We haven't actually started using <FrameworkReference> to build our own packages (#4257), so I'm surprised this has appeared in generated nuspec.

nkolev92 · 2019-04-08T19:17:53Z

As far as I know, the FrameworkReference pack support is not yet merged anywhere.
It'll be in the 5.1.0 NuGet release, but it will still considered a preview feature.

I think understanding @natemcmaster's point is key.

pranavkm · 2019-04-08T19:38:33Z

@JunTaoLuo would you be able to drive investigating the source of the problem?

FYI @Eilon since this is blocking some template work (#6392) that requires a fairly new WebSdk.

JunTaoLuo · 2019-04-08T19:42:11Z

Hmm looks like Microsoft.AspNetCore.ApiAuthorization.IdentityServer failed the task. Looking into why.

EDIT: Actually that's just the first package, whatever the problem is, it's hitting all of our packages probably.

JunTaoLuo · 2019-04-08T20:55:12Z

The packages we build has the following in the nuspec:

    <frameworkReferences>
      <group targetFramework=".NETCoreApp3.0">
        <frameworkReference name="Microsoft.NETCore.App" />
      </group>
    </frameworkReferences>

This is probably what's confusing the Nuget.Packaging.Manifest.ReadFrom API. Seems like it's related to the SDK update.

natemcmaster · 2019-04-08T22:16:33Z

As far as I know, the FrameworkReference pack support is not yet merged anywhere.

It must be if the nuspec generated by the SDK has a framework reference in it.

@pranavkm try updating to NuGet.Build.Tasks 5.1.0-rtm.5921. May require adding a new restore source to https://dotnet.myget.org/F/nuget-build/api/v3/index.json (cref https://github.com/dotnet/toolset/blob/release/3.0.1xx/eng/Versions.props#L55)

nkolev92 · 2019-04-08T23:02:07Z

5.1.0-rtm-5921 is the first insertion into the CLI/SDK that has the FrameworkReference work as far as NuGet is concerned.
And the PR to merge that is on hold dotnet/cli#11054

Which version of the SDK is the one that's creating that nuspec?

I'm not sure how the nuget bits got ingested to cause breakages.
Would this have anything to do with that? dotnet/toolset#593

natemcmaster · 2019-04-08T23:06:28Z

global.json

@@ -1,6 +1,6 @@
 {
  "sdk": {
-    "version": "3.0.100-preview4-010309"
+    "version": "3.0.100-preview4-011136"


@nkolev92 this is the version of the SDK we're trying to update to.

dotnet/toolset#593 (comment)

@nguerrera We're seeing this feature show up in P4 builds of the SDK...did something changed in the last 6 days since this comment, or did this unintentionally get merged into P4?

How does the feature being present break things?

I intentionally did not revert it because I figured we should get coverage of latest bits. There was no expectation of anything breaking. I chatted briefly with @nkolev92 after that comment.

If necessary, we can revert the nuget version in P4.

Note that @pranavkm updated to the latest SDK available as of today.

Understood. The question is why is taking a nuget with the frameworkReferences feature a breaking change?

It breaks the aspnet build because we have some custom MSBuild tasks reading the nuspec, and NuGet code throws when unrecognized elements appear in the metadata.

FWIW, though, the reason we have these custom MSBuild tasks was to workaround the absence of this NuGet feature...so having access to this SDK unblocks us to start using <FrameworkReference> the right way.

@pranavkm was there any particular reason you were trying to update to the latest SDK? If not, maybe we should combine this update with a solution for #4257

Right, essentially there's a mismatch in the toolset which uses nuget 5.1.0-rtm.5921 to build our packages and the NuGet.Build.Tasks that we use to post process the packages built. To reduce the work that's required to update the SDK, which to my understanding is blocking us, why don't we just update the version of NuGet.Build.Tasks that we use to 5.1.0-rtm.5921 as well?

Should be available at https://dotnet.myget.org/feed/nuget-build/package/nuget/NuGet.Build.Tasks/5.1.0-rtm.5921+27af96bdb7ba8d6d7ea9ad53fc76cd1d1aa80703.

@pranavkm was there any particular reason you were trying to update to the latest SDK? If not, maybe we should combine this update with a solution for #4257

There are changes in the WebSDK that are require to the test the preview4 templates.

nguerrera · 2019-04-08T23:16:05Z

And the PR to merge that is on hold dotnet/cli#11054

That's for 2.1.7xx

For 3.0, it was dotnet/toolset#593

nkolev92 · 2019-04-08T23:23:28Z

@nguerrera I think regardless of whether it gets reverted or not, the SDK should set "pack=false" to Microsoft.NETCore.App.

nguerrera · 2019-04-08T23:25:57Z

@nguerrera I think regardless of whether it gets reverted or not, the SDK should set "pack=false" to Microsoft.NETCore.App.

@dsplaisted

JunTaoLuo · 2019-04-09T01:05:54Z

@pranavkm Looks like it's fixed. Feel free to proceed with QB process.

natemcmaster · 2019-04-09T16:24:07Z

I'm a little concerned about accepting this change so late in the branching process. It sounds like there was a lot for churn in the SDK w.r.t. framework references. Before we accept this, can you try using some of the netcoreapp3.0 packages produced by this build to make sure they still work as expected?

pranavkm · 2019-04-09T16:49:21Z

@natemcmaster I agree, it does seem a bit risky at this point. @danroth27 is considering not taking the template change at this point, so we might be happy taking this update in master instead.

Eilon · 2019-04-09T17:43:26Z

OK if there's too much risk and we're not desperate for this change, then let's just do 'master' and let the bits settle.

pranavkm · 2019-04-09T18:21:41Z

Updated to point this to master.

Eilon added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 3, 2019

Eilon requested a review from dougbu April 3, 2019 17:03

dougbu requested changes Apr 3, 2019

View reviewed changes

pranavkm force-pushed the prkrishn/update-sdk branch 2 times, most recently from be01c9c to a141f4b Compare April 6, 2019 00:14

pranavkm marked this pull request as ready for review April 6, 2019 00:20

newer yet

a66515b

pranavkm force-pushed the prkrishn/update-sdk branch from a141f4b to a66515b Compare April 8, 2019 13:55

Try update NuGet.Build

d30f87f

pranavkm closed this Apr 8, 2019

pranavkm reopened this Apr 8, 2019

DEBUG: publish packages on failure

7ec1a35

natemcmaster reviewed Apr 8, 2019

View reviewed changes

Try updating Nuget.Build.Tasks

79c0dd9

Oops

dfc7634

dsplaisted mentioned this pull request Apr 9, 2019

Don't include base FrameworkReferences when creating NuGet packages dotnet/sdk#3102

Merged

JunTaoLuo requested a review from dougbu April 9, 2019 01:42

JunTaoLuo approved these changes Apr 9, 2019

View reviewed changes

pranavkm changed the base branch from master to release/3.0-preview4 April 9, 2019 16:08

dougbu approved these changes Apr 9, 2019

View reviewed changes

pranavkm changed the base branch from release/3.0-preview4 to master April 9, 2019 17:48

pranavkm merged commit 44b8fbc into master Apr 9, 2019

pranavkm deleted the prkrishn/update-sdk branch April 9, 2019 21:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update KoreBuild + SDK #9033

Update KoreBuild + SDK #9033

pranavkm commented Apr 3, 2019

dougbu left a comment

pranavkm commented Apr 6, 2019

dougbu commented Apr 6, 2019

JunTaoLuo commented Apr 6, 2019

dougbu commented Apr 6, 2019

pranavkm commented Apr 8, 2019

JunTaoLuo commented Apr 8, 2019

natemcmaster commented Apr 8, 2019

nkolev92 commented Apr 8, 2019

pranavkm commented Apr 8, 2019

JunTaoLuo commented Apr 8, 2019 •

edited

Loading

JunTaoLuo commented Apr 8, 2019 •

edited

Loading

natemcmaster commented Apr 8, 2019

nkolev92 commented Apr 8, 2019

natemcmaster Apr 8, 2019

natemcmaster Apr 8, 2019

nguerrera Apr 8, 2019

JunTaoLuo Apr 8, 2019

nguerrera Apr 8, 2019

natemcmaster Apr 8, 2019

JunTaoLuo Apr 8, 2019 •

edited

Loading

JunTaoLuo Apr 8, 2019

pranavkm Apr 9, 2019

nguerrera commented Apr 8, 2019

nkolev92 commented Apr 8, 2019

nguerrera commented Apr 8, 2019

JunTaoLuo commented Apr 9, 2019

natemcmaster commented Apr 9, 2019

pranavkm commented Apr 9, 2019

Eilon commented Apr 9, 2019

pranavkm commented Apr 9, 2019

Update KoreBuild + SDK #9033

Update KoreBuild + SDK #9033

Conversation

pranavkm commented Apr 3, 2019

dougbu left a comment

Choose a reason for hiding this comment

pranavkm commented Apr 6, 2019

dougbu commented Apr 6, 2019

JunTaoLuo commented Apr 6, 2019

dougbu commented Apr 6, 2019

pranavkm commented Apr 8, 2019

JunTaoLuo commented Apr 8, 2019

natemcmaster commented Apr 8, 2019

nkolev92 commented Apr 8, 2019

pranavkm commented Apr 8, 2019

JunTaoLuo commented Apr 8, 2019 • edited Loading

JunTaoLuo commented Apr 8, 2019 • edited Loading

natemcmaster commented Apr 8, 2019

nkolev92 commented Apr 8, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JunTaoLuo Apr 8, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nguerrera commented Apr 8, 2019

nkolev92 commented Apr 8, 2019

nguerrera commented Apr 8, 2019

JunTaoLuo commented Apr 9, 2019

natemcmaster commented Apr 9, 2019

pranavkm commented Apr 9, 2019

Eilon commented Apr 9, 2019

pranavkm commented Apr 9, 2019

JunTaoLuo commented Apr 8, 2019 •

edited

Loading

JunTaoLuo commented Apr 8, 2019 •

edited

Loading

JunTaoLuo Apr 8, 2019 •

edited

Loading