Skip to content

Split ILookupNormalizer into Name/Email normalizers #8412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Mar 15, 2019
Merged

Split ILookupNormalizer into Name/Email normalizers #8412

merged 16 commits into from
Mar 15, 2019

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Mar 11, 2019

Fixes #6330

@HaoK HaoK added the area-identity Includes: Identity and providers label Mar 11, 2019
@HaoK HaoK marked this pull request as ready for review March 13, 2019 22:22
@HaoK HaoK requested a review from ajcvickers March 13, 2019 22:22
ajcvickers
ajcvickers approved these changes Mar 15, 2019
View reviewed changes
Copy link
Contributor

@ajcvickers ajcvickers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Pleas make sure it gets documented as a breaking change.

@HaoK
Copy link
Member Author

HaoK commented Mar 15, 2019

Yep announcement for break here #8572 This shouldn't affect many people

@HaoK HaoK merged commit 95ab2fa into master Mar 15, 2019
@blowdart blowdart mentioned this pull request Apr 7, 2019
Open
@natemcmaster natemcmaster deleted the haok/lookup branch May 3, 2019 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajcvickers ajcvickers ajcvickers approved these changes

Assignees
No one assigned
Labels
area-identity Includes: Identity and providers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HaoK @ajcvickers