Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Templates] Imports and CSS tweaks for forms/validation #7914

Merged

Conversation

SteveSandersonMS
Copy link
Member

Following @rynowak's app-building/verification exercise, this PR:

  • Adds Microsoft.AspNetCore.Components.Forms to the default _ViewImports.cshtml in the Components/Blazor templates
  • Adds initial CSS styling for the build-in forms/validation classes so they have a visual effect

These changes are extremely low-risk. They affect the template only, and only in trivial ways. The value of this change is that it cleans up the developer experience around forms and validation, which is one of the key new Components features for Preview 3.

@SteveSandersonMS
Copy link
Member Author

@mkArtakMSFT Do you know if we're still able to take PRs like this one? It's not that anything's badly broken without it, it's just that this improves the developer experience substantially and is very low risk (just CSS and @using changes).

cc @danroth27

Copy link
Member

@rynowak rynowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: from me - if we can't take it for preview3 then we should take this to master

Copy link
Member

@Eilon Eilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for preview3.

@SteveSandersonMS SteveSandersonMS merged commit 87f4ca7 into release/3.0-preview3 Feb 25, 2019
@SteveSandersonMS SteveSandersonMS deleted the stevesa/editing-template-polish branch February 25, 2019 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants