Remove web::uri usage from public API #7834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did web::uri do any validation? If so, what happens now when I try to start the connection with a uri string would be an invalid web::uri? For example, does the http_client ctor start throwing? |
Yes, I believe this will throw now, as it converts the string into a |
halter73
reviewed
Feb 22, 2019
| } | ||
| catch (...) | ||
| { | ||
| // We shouldn't check the exact exception as it would be specific to the http library being used |
There was a problem hiding this comment.
What is the exception with the default http library? Does it make it clear the URI is invalid?
There was a problem hiding this comment.
"provided uri is invalid: :1 ä bad_uri&a=b"
halter73
approved these changes
Feb 22, 2019
BrennanConroy
force-pushed
the
brecon/clean2
branch
from
93d3164 to
b558753
Compare
|
/azp run AspNetCore-ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed a couple redundant tests and enabled some of the disabled ones since they should be fixed.
Deleted some old unused code I found too.
And fixed a flaky build issue with copying a dll