Skip to content

Fix static web assets lock-race issue for E2E tests #68504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Fix static web assets lock-race issue for E2E tests #68504

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e7788f
Initial plan
Copilot Aug 13, 2026
fc00a63
Serialize trimmed app publishes
Copilot Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Components/test/E2ETest/Microsoft.AspNetCore.Components.E2ETests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@

<TestTrimmedApps Condition="'$(ContinuousIntegrationBuild)' == 'true'">true</TestTrimmedApps>
<TestTrimmedApps Condition="'$(Configuration)' == 'Release'">true</TestTrimmedApps>
<!-- The trimmed app publishes share project intermediate outputs, so their project references cannot run concurrently. -->
<BuildInParallel Condition="'$(TestTrimmedApps)' == 'true'">false</BuildInParallel>

@kotlarmilos kotlarmilos Aug 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this increase CI time? Do we want to ensure that apps use separate intermediate directories?

@maraf maraf Aug 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does it happen that a single app is published in parallel (more than once) for a single build?
Isn't the underlaying issue in msbuild not reusing existing build/project instance?
Possibly by passing different props?

@PureWeen PureWeen Aug 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot assess and resolve please

Copilot AI Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessed; I don’t think a code change is needed beyond fc00a63. This can increase only the Release/CI Components E2E trimmed-app preparation because those trimmed app project references now run serially; Debug/local and product builds keep their existing parallelism.

Separate intermediate directories would need to partition the referenced framework project intermediates, not just each app's PublishDir, because the collision is under artifacts\obj\Microsoft.AspNetCore.Components.WebAssembly\Release\net11.0\compressed\publish\.... That would be a broader and likely more expensive workaround.

This isn't one app intentionally being published twice. The E2E project publishes multiple trimmed apps in parallel, and those nested publishes each traverse Microsoft.AspNetCore.Components.WebAssembly with the same effective Configuration/TFM/static-web-asset identity. MSBuild doesn't coalesce those nested Publish traversals across the parallel project-reference invocations, so serializing at the E2E project owner is the smallest scoped fix.

</PropertyGroup>

<ItemGroup>
Expand Down
Loading