Exclude localize files from newline check and remove trailing newlines from templatestrings.*.json #64911

Copilot · 2026-01-02T10:43:51Z

You've read the Contributor Guide and Code of Conduct.
You've included unit or integration tests for your change, where applicable.
You've included inline docs for your change, where applicable.
There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Undo newline-related changes from PR #64829

Description

PR #64829 added trailing newlines to auto-generated localization files and included them in newline validation tests. This PR reverts only those specific newline-related changes while preserving all other improvements from that PR.

Changes:

Updated NewlineEndingTest.cs to exclude .template.config/localize/ directory files from newline validation checks, as these are auto-generated localization files
Removed trailing newlines from all 350 templatestrings.*.json files in .template.config/localize/ directories across Web.ProjectTemplates, Web.ItemTemplates, and Web.Client.ItemTemplates

All changes from PR #64829 are preserved:

All 27 template.json files across Web.ProjectTemplates, Web.ItemTemplates, and Web.Client.ItemTemplates
UsingToolTemplateLocalizer configuration in all template project .csproj files
Shared/BlazorTemplateTest.cs and Shared/TestOutputLogger.cs test helper classes
All test infrastructure and test file changes

The changes restore the original state where auto-generated localization files are excluded from newline validation and do not have trailing newlines.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com>

…te.json files Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com>

javiercn · 2026-01-02T11:07:16Z

@copilot var filesWithoutNewlineEnding = new List();

    // Get all template source files (excluding third-party libraries and auto-generated localization files)
    // Get all template source files (excluding third-party libraries)
    var files = Directory.GetFiles(templateDirectoryPath, "*.cs", SearchOption.AllDirectories)
        .Concat(Directory.GetFiles(templateDirectoryPath, "*.fs", SearchOption.AllDirectories))
        .Concat(Directory.GetFiles(templateDirectoryPath, "*.razor", SearchOption.AllDirectories))
        .Concat(Directory.GetFiles(templateDirectoryPath, "*.xml", SearchOption.AllDirectories))
        .Concat(Directory.GetFiles(templateDirectoryPath, "*.csproj", SearchOption.AllDirectories))
        .Concat(Directory.GetFiles(templateDirectoryPath, "*.fsproj", SearchOption.AllDirectories))
        .Where(f => !f.Contains($"{Path.DirectorySeparatorChar}wwwroot{Path.DirectorySeparatorChar}lib{Path.DirectorySeparatorChar}")) // Exclude third-party libraries
        .Where(f => !f.Contains($"{Path.DirectorySeparatorChar}.template.config{Path.DirectorySeparatorChar}localize{Path.DirectorySeparatorChar}")); // Exclude auto-generated localization files in localize directory
        .Where(f => !f.Contains($"{Path.DirectorySeparatorChar}wwwroot{Path.DirectorySeparatorChar}lib{Path.DirectorySeparatorChar}")); // Exclude third-party libraries

    foreach (var file in files)
    {

This diff should be undone.

The changes for adding new lines to all the **/.template.config/localize/templatestrings.*.json files should be undone

…s from templatestrings.*.json files Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com>

Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com>

Copilot · 2026-01-02T11:14:47Z

@copilot var filesWithoutNewlineEnding = new List();

    // Get all template source files (excluding third-party libraries and auto-generated localization files)...

Done in commits f7359d7 and 3d7e32e. Updated NewlineEndingTest.cs to exclude .template.config/localize/ files from the newline check, and removed trailing newlines from all 350 templatestrings.*.json files.

javiercn

undo the deletion of all the template.json files

javiercn · 2026-01-02T14:56:58Z

src/ProjectTemplates/Shared/BlazorTemplateTest.cs

@copilot Undo the delete of this file

Restored in commit b35f514.

javiercn · 2026-01-02T14:57:06Z

src/ProjectTemplates/Shared/TestOutputLogger.cs

@copilot Undo the delete of this file

Restored in commit b35f514.

javiercn · 2026-01-02T14:57:25Z

src/ProjectTemplates/test/Templates.Blazor.WebAssembly.Auth.Tests/BlazorWasmTemplateAuthTest.cs

@copilot Undo changes to this file

Reverted to original state in commit b35f514.

javiercn · 2026-01-02T14:57:51Z

src/ProjectTemplates/test/Templates.Blazor.WebAssembly.Tests/BlazorWasmTemplateTest.cs

@copilot Undo changes to this file

Reverted to original state in commit b35f514.

javiercn · 2026-01-02T14:58:29Z

src/ProjectTemplates/Web.Client.ItemTemplates/content/Less/.template.config/template.json

@copilot Undo the delete of this file

Restored in commit b35f514.

javiercn · 2026-01-02T14:59:37Z

src/ProjectTemplates/Web.ProjectTemplates/Microsoft.DotNet.Web.ProjectTemplates.csproj

Undo this change

Reverted in commit b35f514.

…leted Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com>

Copilot · 2026-01-02T15:05:11Z

undo the deletion of all the template.json files

Restored all template.json files in commit b35f514.

javiercn

LGTM

Copilot

Copilot wasn't able to review any files in this pull request.

ilonatommy · 2026-01-05T12:26:20Z

/ba-g GeneratorTests are broken across multiple PRs, it's not connected

Initial plan

61cb466

Copilot AI assigned Copilot and javiercn Jan 2, 2026

dotnet-policy-service bot added the Attention: Shared Code Modified label Jan 2, 2026

Copilot started work on behalf of javiercn January 2, 2026 10:44 View session

Copilot AI and others added 2 commits January 2, 2026 10:55

Remove template.json files and adjust test code

17f1b52

Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com>

Disable UsingToolTemplateLocalizer to fix build after removing templa…

64c6e08

…te.json files Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Remove changes to template.json files and adjust tests~~ Revert template.json files and UsingToolTemplateLocalizer changes from PR #64829 Jan 2, 2026

Copilot AI requested a review from javiercn January 2, 2026 11:04

Copilot finished work on behalf of javiercn January 2, 2026 11:04

Copilot started work on behalf of javiercn January 2, 2026 11:07 View session

Exclude localize files from newline check and remove trailing newline…

f7359d7

…s from templatestrings.*.json files Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com>

ilonatommy mentioned this pull request Jan 2, 2026

Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 2870495 #64899

Closed

Remove trailing newlines from remaining templatestrings.*.json files

3d7e32e

Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com>

Copilot AI changed the title ~~Revert template.json files and UsingToolTemplateLocalizer changes from PR #64829~~ Exclude localize files from newline check and remove trailing newlines from templatestrings.*.json Jan 2, 2026

Copilot finished work on behalf of javiercn January 2, 2026 11:17

javiercn requested changes Jan 2, 2026

View reviewed changes

Copilot started work on behalf of javiercn January 2, 2026 15:00 View session

Restore template.json files and test helpers that were incorrectly de…

b35f514

…leted Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com>

Copilot AI requested a review from javiercn January 2, 2026 15:08

Copilot finished work on behalf of javiercn January 2, 2026 15:08

javiercn approved these changes Jan 2, 2026

View reviewed changes

javiercn requested a review from ilonatommy January 2, 2026 15:41

ilonatommy approved these changes Jan 2, 2026

View reviewed changes

This was referenced Jan 2, 2026

Unable to read data from the transport connection: An existing connection was forcibly closed by the remote host. dotnet/dnceng#5922

Open

Known Build Error: error : Cannot create a file when that file already exists. #61178

Open

javiercn added the area-blazor Includes: Blazor, Razor Components label Jan 4, 2026

ilonatommy mentioned this pull request Jan 5, 2026

Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 2871750 #64918

Closed

javiercn marked this pull request as ready for review January 5, 2026 10:30

javiercn requested a review from a team as a code owner January 5, 2026 10:30

Copilot AI review requested due to automatic review settings January 5, 2026 10:30

Copilot AI reviewed Jan 5, 2026

View reviewed changes

javiercn merged commit b12011f into main Jan 5, 2026
23 of 25 checks passed

javiercn deleted the copilot/remove-template-json-changes branch January 5, 2026 12:41

dotnet-policy-service bot added this to the 11.0-preview1 milestone Jan 5, 2026

dotnet-maestro bot mentioned this pull request Jan 8, 2026

[main] Source code updates from dotnet/aspnetcore dotnet/dotnet#4110

Merged

Exclude localize files from newline check and remove trailing newlines from templatestrings.*.json #64911

Exclude localize files from newline check and remove trailing newlines from templatestrings.*.json #64911

Uh oh!

Conversation

Copilot AI commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

javiercn commented Jan 2, 2026

Uh oh!

Copilot AI commented Jan 2, 2026

Uh oh!

javiercn left a comment

Choose a reason for hiding this comment

Uh oh!

javiercn Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

javiercn Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

javiercn Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

javiercn Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

javiercn Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

javiercn Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Jan 2, 2026

Uh oh!

javiercn left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

ilonatommy commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Jan 2, 2026 •

edited

Loading

ilonatommy commented Jan 5, 2026 •

edited

Loading