Skip to content

Update RefreshSignInAsync documentation and remove unnecessary null-conditional operators #64278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
+9 −5
Draft

Update RefreshSignInAsync documentation and remove unnecessary null-conditional operators #64278

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
45900c9
Initial plan
Copilot Nov 7, 2025
6bd9dbb
Update RefreshSignInAsync documentation and fix null checks
Copilot Nov 7, 2025
8c94c54
Remove unnecessary null check for auth result
Copilot Nov 7, 2025
6b55648
Fix XML documentation method reference
Copilot Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/Identity/Core/src/SignInManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,10 +165,14 @@ public virtual async Task<bool> CanSignInAsync(TUser user)
}

/// <summary>
/// Signs in the specified <paramref name="user"/>, whilst preserving the existing
/// Refreshes the sign-in for the specified <paramref name="user"/>, whilst preserving the existing
/// AuthenticationProperties of the current signed-in user like rememberMe, as an asynchronous operation.
/// </summary>
/// <param name="user">The user to sign-in.</param>
/// <remarks>
/// The user must already be signed in, and the user ID must match the currently authenticated user.
/// If the user is not signed in, use <see cref="SignInAsync(TUser, bool, string?)"/> instead.
/// </remarks>
/// <param name="user">The user to refresh the sign-in for.</param>
/// <returns>The task object representing the asynchronous operation.</returns>
public virtual async Task RefreshSignInAsync(TUser user)
{
Expand Down Expand Up @@ -204,8 +208,8 @@ public virtual async Task RefreshSignInAsync(TUser user)
}

IList<Claim> claims = Array.Empty<Claim>();
var authenticationMethod = auth.Principal?.FindFirst(ClaimTypes.AuthenticationMethod);
var amr = auth.Principal?.FindFirst("amr");
var authenticationMethod = auth.Principal.FindFirst(ClaimTypes.AuthenticationMethod);
var amr = auth.Principal.FindFirst("amr");

if (authenticationMethod != null || amr != null)
{
Expand All @@ -221,7 +225,7 @@ public virtual async Task RefreshSignInAsync(TUser user)
}

await SignInWithClaimsAsync(user, auth.Properties, claims);
return (true, auth.Properties?.IsPersistent ?? false);
return (true, auth.Properties.IsPersistent);
}

/// <summary>
Expand Down
Loading