-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Mark productVersion.txt as shipping artifact in 8.0 #64067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: mmitche <8725170+mmitche@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR corrects the shipping artifact classification for version files in the ASP.NET Core 8.0 build configuration. The productVersion.txt and aspnetcore-productVersion.txt files were incorrectly marked as non-shipping artifacts, which would prevent them from being published to their expected CDN locations.
Key Changes:
- Updated
ManifestArtifactDataproperty fromNonShipping=truetoNonShipping=falsefor both version files
Summary
Fixes the issue where
productVersion.txtandaspnetcore-productVersion.txtwere incorrectly marked as non-shipping artifacts in the ASP.NET Core 8.0 build configuration. These files are required in the final CDN locations and must be marked as shipping artifacts.Changes
Modified
eng/Publishing.propsto change theManifestArtifactDataproperty fromNonShipping=truetoNonShipping=falsefor both:productVersion.txtaspnetcore-productVersion.txtThis ensures these version files are properly included in the shipping manifest and published to the correct CDN locations alongside other shipping artifacts.
Impact
Without this change, the productVersion.txt files would not be available in the expected CDN locations, which could impact downstream consumers that rely on these files to determine the ASP.NET Core runtime version.
Fixes #[issue_number]
Original prompt
Fixes #64066
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.