[release/10.0] [backport fix] Fix Validation source generator deployment for non-Web SDKs #63734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oroztocil
added
the
Servicing-consider
There was a problem hiding this comment.
Pull Request Overview
This PR completes a previously incomplete backport by adding missing changes that restore throwing behavior for well-known type resolution in the Validation source generator. The original backport only partially addressed the issue of making the generator work with non-Web SDKs.
- Adds
GetOptionalmethod toWellKnownTypesfor graceful handling of missing types - Updates specific type lookups to use
GetOptionalfor ASP.NET Core HTTP types that may be missing in non-Web SDKs - Preserves throwing behavior for other type lookups to maintain early detection of packaging issues
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Validation/gen/Parsers/ValidationsGenerator.TypesParser.cs | Updates calls to use GetOptional for ASP.NET Core service metadata types |
| src/Validation/gen/Extensions/ITypeSymbolExtensions.cs | Updates exempt type checks to use GetOptional for HTTP-related types |
| src/Shared/RoslynUtils/WellKnownTypes.cs | Adds GetOptional method and restores throwing behavior for Get method |
javiercn
approved these changes
Sep 19, 2025
lewing
approved these changes
Sep 19, 2025
danmoseley
added
Servicing-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #63687 to release/10.0
[backport fix] Fix Validation source generator deployment for non-Web SDKs
This PR fixes incomplete backport #63715.
Description
I forgot to update that PR with an additional commit that I pushed into the original approved bugfix PR (https://github.com/dotnet/aspnetcore/pull/63687/commits) after code review.
The missing commit lessens the impact of the merged change on other ASP.NET Core analyzers (other than the Validation source generator). In particular, the commit re-enables throwing behavior of certain checks that were put in place to spot packaging problems.
Customer Impact
There is no direct customer impact but the partial change decreases our ability to spot packaging issues early.
Regression?
Risk
This fix decreases risk of packaging errors going unnoticed.
Verification
Packaging changes reviewed?
When servicing release/2.3