Convert Azure hosting startup and integration projects to use ProjectRef #6207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rynowak
added a commit
to dotnet/razor
that referenced
this pull request
Dec 31, 2018
The bug here is that we have extra whitespace being written out when the component renders. This happens because parser adds an empty C# statement node to wrap all of the whitespace that precedes `@functions`. This is tracked by dotnet/aspnetcore#6207. To fix this issue I'm allowing the whitespace pass to skip over an empty C# statement to remove whitespace. This is sound because an empty C# statement produces no output - we allow removing whitespace before and after all nodes that produce no output.
rynowak
added a commit
to dotnet/razor
that referenced
this pull request
Dec 31, 2018
The bug here is that we have extra whitespace being written out when the component renders. This happens because parser adds an empty C# statement node to wrap all of the whitespace that precedes `@functions`. This is tracked by dotnet/aspnetcore#6207. To fix this issue I'm allowing the whitespace pass to skip over an empty C# statement to remove whitespace. This is sound because an empty C# statement produces no output - we allow removing whitespace before and after all nodes that produce no output.
This code was written for a partner team, but never shipped to customers
|
Updated to remove Microsoft.Extensions.ApplicationModelDetection |
pakrym
approved these changes
Jan 2, 2019
JunTaoLuo
pushed a commit
that referenced
this pull request
May 7, 2020
The bug here is that we have extra whitespace being written out when the component renders. This happens because parser adds an empty C# statement node to wrap all of the whitespace that precedes `@functions`. This is tracked by #6207. To fix this issue I'm allowing the whitespace pass to skip over an empty C# statement to remove whitespace. This is sound because an empty C# statement produces no output - we allow removing whitespace before and after all nodes that produce no output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #4246 for a subset of projects in src/AzureIntegration.
There is still code left in src/AzureIntegration. It's unclear if this code needs to be kept. I've started email to figure out if it's okay to delete the left over code in src/AzureIntegration which was used for these projects: