Register LazyAssemblyLoader to DI in AddInteractiveWebAssemblyComponents #61822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiercn
approved these changes
May 7, 2025
|
Fixes #51966 |
|
backport ? |
|
@pavelsavara I think it might be problematic adding a reference on a patch release. I might be wrong, but I remember one time we broke things in a patch doing something similar, so unless we need it, we can avoid it. People can do this manually if they need to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to register LazyAssemblyLoader in AddInteractiveWebAssemblyComponents in order to prevent the confusing situation where a component that injects LazyAssemblyLoader works in the WebAssembly client but crashes during prerendering. (Note that it works when the wasm client takes over because WebAssemblyHostBuilder.CreateDefault registers LazyAssemblyLoader.)