Skip to content

[Blazor] Use Microsoft.DotNet.HotReload.Agent package #61821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 13, 2025
Merged

[Blazor] Use Microsoft.DotNet.HotReload.Agent package #61821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1c7b72f
Add dependency
maraf May 6, 2025
9120543
Add .Data dependency
maraf May 7, 2025
52f3842
Use agent from source package
maraf May 7, 2025
5755b72
Ignore editor config for agent files
maraf May 7, 2025
91823fb
Merge remote-tracking branch 'upstream/main' into BlazorHotReloadPackage
maraf May 7, 2025
f887036
Update dependency
maraf May 9, 2025
aa66f3a
Merge branch 'main' into BlazorHotReloadPackage
maraf May 9, 2025
fd968e8
Merge remote-tracking branch 'upstream/main' into BlazorHotReloadPackage
maraf May 12, 2025
3c63861
Merge branch 'main' into BlazorHotReloadPackage
maraf May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,6 +464,13 @@ dotnet_diagnostic.IDE0161.severity = silent
# IDE0005: Remove unused usings. Ignore for shared src files since imports for those depend on the projects in which they are included.
dotnet_diagnostic.IDE0005.severity = silent

[{**/microsoft.dotnet.hotreload.agent*/**.cs}]
# IDE0005: Remove unused usings. Ignore for shared src files coming from nuget package.
dotnet_diagnostic.IDE0005.severity = silent
# IDE0073: A source file is missing a required header. Ignore for shared src files coming from nuget package.
dotnet_diagnostic.IDE0073.severity = silent


# Verify settings
[*.{received,verified}.{txt,xml,json}]
charset = "utf-8-bom"
Expand Down
2 changes: 2 additions & 0 deletions eng/Dependencies.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ and are generated based on the last package release.
<LatestPackageReference Include="Microsoft.CodeAnalysis.ExternalAccess.AspNetCore" />
<LatestPackageReference Include="Microsoft.CodeAnalysis.Razor" />
<LatestPackageReference Include="Microsoft.CSharp" />
<LatestPackageReference Include="Microsoft.DotNet.HotReload.Agent" />
<LatestPackageReference Include="Microsoft.DotNet.HotReload.Agent.Data" />
Comment on lines +28 to +29
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this essentially a sources package?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, is the plan for this code to end up in the runtime eventually (To enable HotReload outside Blazor).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this essentially a sources package?

Yes

Also, is the plan for this code to end up in the runtime eventually (To enable HotReload outside Blazor).

Yes-ish. The plan is that it ends somewhere, where runtime template can use it as well, including the bootstrap logic. I don't know that exact shape yet

<LatestPackageReference Include="Microsoft.Extensions.Caching.Abstractions" />
<LatestPackageReference Include="Microsoft.Extensions.Caching.Memory" />
<LatestPackageReference Include="Microsoft.Extensions.Configuration.Abstractions" />
Expand Down
8 changes: 8 additions & 0 deletions eng/Version.Details.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,6 +361,14 @@
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>85778473549347b3e4bad3ea009e9438df7b11bb</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.HotReload.Agent" Version="10.0.100-preview.5.25258.39">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>5e6dacd4d3debda3266224b2a434811c6fa94987</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.HotReload.Agent.Data" Version="10.0.100-preview.5.25258.39">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>5e6dacd4d3debda3266224b2a434811c6fa94987</Sha>
</Dependency>
</ProductDependencies>
<ToolsetDependencies>
<!-- Listed explicitly to workaround https://github.com/dotnet/cli/issues/10528 -->
Expand Down
3 changes: 3 additions & 0 deletions eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,9 @@
<MicrosoftEntityFrameworkCoreToolsVersion>10.0.0-preview.4.25260.104</MicrosoftEntityFrameworkCoreToolsVersion>
<MicrosoftEntityFrameworkCoreVersion>10.0.0-preview.4.25260.104</MicrosoftEntityFrameworkCoreVersion>
<MicrosoftEntityFrameworkCoreDesignVersion>10.0.0-preview.4.25260.104</MicrosoftEntityFrameworkCoreDesignVersion>
<!-- Packages from dotnet/sdk -->
<MicrosoftDotNetHotReloadAgentVersion>10.0.100-preview.5.25258.39</MicrosoftDotNetHotReloadAgentVersion>
<MicrosoftDotNetHotReloadAgentDataVersion>10.0.100-preview.5.25258.39</MicrosoftDotNetHotReloadAgentDataVersion>
<!-- Packages from dotnet/roslyn -->
<!-- Not updated automatically -->
<MicrosoftCodeAnalysisCommonVersion>4.13.0-3.24613.7</MicrosoftCodeAnalysisCommonVersion>
Expand Down
11 changes: 0 additions & 11 deletions src/Components/WebAssembly/WebAssembly/src/HotReload/AgentMessageSeverity.cs
View file
Open in desktop

This file was deleted.

30 changes: 0 additions & 30 deletions src/Components/WebAssembly/WebAssembly/src/HotReload/AgentReporter.cs
View file
Open in desktop

This file was deleted.

203 changes: 0 additions & 203 deletions src/Components/WebAssembly/WebAssembly/src/HotReload/HotReloadAgent.cs
View file
Open in desktop

This file was deleted.

Loading
Loading