Skip to content

Fix missing VMR assets in SiteExtensions packages #61233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 1, 2025
Merged

Fix missing VMR assets in SiteExtensions packages #61233

merged 4 commits into from
Apr 1, 2025

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Mar 29, 2025 •
edited
Loading

Should fix #61185, #61187.

Current test build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2674842&view=results

After this change:

Issues: 1217
Baselined issues: 837
Detailed issue counts by type:
MissingShipping: Issues w/o Baseline = 338, Baselined issues = 96
MissingNonShipping: Issues w/o Baseline = 114, Baselined issues = 0
MisclassifiedAsset: Issues w/o Baseline = 2, Baselined issues = 0
AssemblyVersionMismatch: Issues w/o Baseline = 5, Baselined issues = 741
MissingPackageContent: Issues w/o Baseline = 435, Baselined issues = 0
ExtraPackageContent: Issues w/o Baseline = 9, Baselined issues = 0
PackageMetadataDifference: Issues w/o Baseline = 237, Baselined issues = 0
PackageTFMs: Issues w/o Baseline = 1, Baselined issues = 0
PackageDependencies: Issues w/o Baseline = 76, Baselined issues = 0

@wtgodbe wtgodbe requested review from ViktorHofer, mmitche and a team March 29, 2025 23:42
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically label Mar 29, 2025
@wtgodbe wtgodbe added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework and removed needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically labels Mar 30, 2025
@build-analysis build-analysis bot mentioned this pull request Mar 31, 2025
Open
3 tasks
@wtgodbe wtgodbe enabled auto-merge (squash) March 31, 2025 20:28
@build-analysis build-analysis bot mentioned this pull request Mar 31, 2025
Open
3 tasks
@wtgodbe wtgodbe merged commit fc067c3 into main Apr 1, 2025
27 checks passed
@wtgodbe wtgodbe deleted the wtgodbe/MoreMissingAssets branch April 1, 2025 00:02
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview4 milestone Apr 1, 2025
@wtgodbe wtgodbe mentioned this pull request Apr 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmitche mmitche mmitche approved these changes

@ViktorHofer ViktorHofer Awaiting requested review from ViktorHofer

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
10.0-preview4
Development

Successfully merging this pull request may close these issues.

AspNetCoreRuntime.10.0.x64/x86 nupkgs - Missing the aspnetcore shared runtime
2 participants
@wtgodbe @mmitche