-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build.cmd/sh changes #5958
build.cmd/sh changes #5958
Conversation
…bfolders or subgroups of projects * Add build scripts for ci * Remove obsolete scripts * Add flags like --test and --pack to control running just test or packaging * Add flags like --managed and --native to control building sub-types of projects * Remove KoreBuild bootstrapper flags
…ding subfolders or subgroups of projects
PR build failures uncovered a product issue: dotnet/extensions#815 I'm going to revert some of these changes temporarily until we can resolved. |
Is |
Yes, that should still work. You can also do |
resx should be included in the buildfromsource.md. |
Produce packages. | ||
|
||
.PARAMETER Test | ||
Run tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I understood whether this only runs tests, or does it also build some subset of things required to run tests? And if it literally only runs tests (i.e. it assumes all binaries are already built and in the right location), when would that be needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build.cmd -test
will build AND test. We could add a gesture for just running tests without building, but I don't think re-running tests without changes is very common.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@halter73 does this all the time, re-running tests in a loop trying to repro flaky issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I was thinking it presumably builds & runs tests.
The case of re-running tests in a loop happens, but is rare, so I didn't think that would be a frequently used case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the build were incremental then it would work both ways...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds should be incremental once we finish #4246.
re-running tests in a loop trying to repro flaky issues.
You can do it with the build.cmd script, it's just not the default. On *nix, build.sh --no-restore --no-build --test
. On Windows, it's ./build.ps1 -restore:$false -build:$false -test
. You can also use dotnet test --no-build
on the project you're trying to use.
</PropertyGroup> | ||
|
||
<Exec Command="npm $(NpmInstallCommand)" WorkingDirectory="%(NpmProjectDirectory.Identity)" Condition=" '%(NpmProjectDirectory.Identity)' != '' " /> | ||
<!-- Always run `npm ci` because `npm install` has a tendancy to churn package-lock.json for no apparent reason. --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/AzurePipelines run all |
Success! 2 created and queued. |
🔔 I'm going to merge this soon. Please take a look if you want to provide additional feedback. |
🚢 🇮🇹 |
Update the build scripts to support building subfolders or subgroups of projects * Add build scripts for ci * Remove obsolete scripts * Add flags like --test and --pack to control running just test or packaging * Add flags like --managed and --native to control building sub-types of projects * Remove KoreBuild bootstrapper flags * Update to extensions 3.0.0-preview.18619.1 (needed to get a fix for dotnet/extensions#815 to make this change work on MSBuild.exe) Commit migrated from dotnet/aspnetcore@c3beb1f9b149
Notes for @aspnet contributors
build.cmd
no longer runs tests. Runbuild.cmd -test
Changes:
These scripts will change a little more when we adopt Arcade SDK, but not much.
Resolves #4247