Skip to content

Remove the Shared Framework WixLib in favor of the MSI installer #59351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 8, 2024
Merged

Remove the Shared Framework WixLib in favor of the MSI installer #59351

merged 5 commits into from
Dec 8, 2024

Conversation

jkoritzinsky
Copy link
Member

Remove SharedFX Wixlib

Description

Remove the shared framework wixlib. Depends on dotnet/sdk#45346.

The only place that uses the wixlib's logic is the Windows Hosting Bundle, which has its own copy of the logic.

Removing the wixlib gets us a few things:

  • Once the SDK PR is merged, there's no consumers outside of the repo.
  • We can move to using the Microsoft.DotNet.Build.Tasks.Installers logic for building the Shared Framework MSI and bundle once we don't use the wixlib
  • The wixlib is the only consumer of the CreateLitCommandPackage task, so we can remove that once we remove the wixlib.

@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Dec 6, 2024
@jkoritzinsky
Inline the MsiPackage items and heavily simplify the logic to just bu…
17c52e6 
…ndle the correct MSI into the SFX exe bundle.
@jkoritzinsky jkoritzinsky added the blocked The work on this issue is blocked due to some dependency label Dec 6, 2024
@jkoritzinsky jkoritzinsky marked this pull request as ready for review December 6, 2024 18:33
@jkoritzinsky jkoritzinsky requested review from wtgodbe and a team as code owners December 6, 2024 18:33
@jkoritzinsky jkoritzinsky requested review from joeloff and removed request for wtgodbe December 6, 2024 18:34
@jkoritzinsky jkoritzinsky mentioned this pull request Dec 6, 2024
Merged
@jkoritzinsky jkoritzinsky removed the blocked The work on this issue is blocked due to some dependency label Dec 8, 2024
@jkoritzinsky
Copy link
Member Author

/azp run aspnetcore-ci

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkoritzinsky jkoritzinsky enabled auto-merge (squash) December 8, 2024 18:57
@jkoritzinsky jkoritzinsky merged commit e2a857c into dotnet:main Dec 8, 2024
27 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Dec 8, 2024
@jkoritzinsky jkoritzinsky deleted the no-wixlib branch December 9, 2024 00:03
captainsafia pushed a commit that referenced this pull request Feb 11, 2025
@jkoritzinsky @captainsafia
Remove the Shared Framework WixLib in favor of the MSI installer (#59351
3f18b12 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes

@joeloff joeloff Awaiting requested review from joeloff

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
10.0-preview1
Development

Successfully merging this pull request may close these issues.
2 participants
@jkoritzinsky @wtgodbe