Skip to content

Replaced Deprecated str.substr with str.substring in All Relevant Files #58732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2024
Merged

Replaced Deprecated str.substr with str.substring in All Relevant Files #58732

merged 1 commit into from
Nov 1, 2024

Conversation

shethaadit
Copy link
Contributor

@shethaadit shethaadit commented Oct 31, 2024 •
edited
Loading

Replaced Deprecated str.substr with str.substring

Description

  • Fixed deprecation warnings in Visual Studio by replacing str.substr with str.substring.
  • Applied changes in all relevant TypeScript and JavaScript files to prevent future compatibility issues.
  • Ensured compatibility and future-proofed the code against potential deprecation-related issues.

Fixes #58720

@shethaadit shethaadit requested review from BrennanConroy, halter73 and a team as code owners October 31, 2024 21:37
@ghost ghost added the area-signalr Includes: SignalR clients and servers label Oct 31, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Oct 31, 2024
@BrennanConroy BrennanConroy merged commit 46ea84f into dotnet:main Nov 1, 2024
27 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Nov 1, 2024
captainsafia pushed a commit that referenced this pull request Feb 11, 2025
@shethaadit @captainsafia
Updated deprecated substr and relaced it with substring. (#58732)
98c16d9 
Co-authored-by: Adit Sheth <adsheth@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrennanConroy BrennanConroy BrennanConroy approved these changes

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

Assignees

@adityamandaleeka adityamandaleeka

Labels
area-signalr Includes: SignalR clients and servers community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
10.0-preview1
Development

Successfully merging this pull request may close these issues.

Deprecated str.substr warning
3 participants
@shethaadit @BrennanConroy @adityamandaleeka