Implement the Mvc PushFileStreamResult API

[0xced]

Mvc PushFileStreamResult API

• You've read the Contributor Guide and Code of Conduct.
• You've included unit or integration tests for your change, where applicable.
• You've included inline docs for your change, where applicable.
• There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

This pull request implements PushFileStreamResult as described in #39383 along with the related File overloads on the ControllerBase class and the PushFileStreamResultExecutor.

Fixes #39383

[dotnet-policy-service]

Thanks for your PR, @0xced. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

[dotnet-policy-service]

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

[captainsafia]

Thanks for taking the time to work on this, @0xced!

This looks good overall. To make sure that everything's checked, can you open a new API proposal issue specifically for the MVC-related changes? I'm hoping the review can happen fairly quickly since they build on top of the IResult-based implementations but I'd like to make sure we get the right scrutiny for the new methods on ControllerBase.

[captainsafia]

Why SkipEnabledCheck = true here?

[0xced]

Because ExecutingFileResultWithNoFileName is already surrounded by if (logger.IsEnabled(LogLevel.Information)) inside the ExecutingFileResult method, exactly like in FileContentResultExecutor.

Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (2)

• src/Mvc/Mvc.Core/src/PublicAPI.Unshipped.txt: Language not supported
• src/Mvc/Mvc.Core/test/PushFileStreamResultTest.cs: Evaluated as low risk

Comments suppressed due to low confidence (1)

src/Mvc/Mvc.Core/src/Infrastructure/PushFileStreamResultExecutor.cs:64

• The 'WriteFileAsync' method should handle the 'range' and 'rangeLength' parameters correctly, ensuring they are 'null' and '0' respectively, or handle them appropriately if they are not.

Debug.Assert(range == null);

[dotnet-policy-service]

Hi @0xced.
It seems you haven't touched this PR for the last two weeks. To avoid accumulating old PRs, we're marking it as stale. As a result, it will be closed if no further activity occurs within 4 days of this comment. You can learn more about our Issue Management Policies here.

[0xced]

Please don't close this pull request.