feat: DefaultOutputCachePolicyProvider added

[onurkanbakirci]

DefaultOutputCachePolicyProvider implemented

Description

#52419 implemented.

I have added the DefaultOutputCachePolicyProvider, implemented the IOutputCachePolicyProvider interface, and written tests for them.

@witskeeper , @halter73

[halter73]

There are two comments from API review that I think were missed:

• We don't think the implementation needs to be public.

• The current middleware should use this interface without accessing the options directly to make replacing the implementation useful.

The idea was that AddOutputCache should add the internal DefaultOutputCachePolicyProvider with DI as an IOutputCachePolicyProvider and then use that in the middleware probably here.

@sebastienros Can you also take a look at this?

[halter73]

We still need to update AddOutputCache to add the new DefaultOutputCachePolicyProvider and then remove the DefaultOutputCachePolicyProvider related changes to PublicAPI.Unshipped.txt since it's no longer public.

[mkArtakMSFT]

@halter73 is the expectation here that this change should be expanded to address the feedback from the API review?

[halter73]

is the expectation here that this change should be expanded to address the feedback from the API review?

Basically. At a minimum, we need to add the new service to the collection in AddOutputCache and also update PublicAPI.Unshipped.txt so that the build passes.

Now that the service implementation type is internal, no one will be able to use it unless AddOutputCache adds it making this whole change pointless. Even if the implementation type remained public, we'd want to add the implementation to the service collection for convenience.

The other thing that came up in API review was how the middleware should use the registered IOutputCachePolicyProvider to look up named policies. Not doing so would be counterintuitive. We'd want to test this behavior as well to ensure no regressions.

• The current middleware should use this interface without accessing the options directly to make replacing the implementation useful.

The idea was that AddOutputCache should add the internal DefaultOutputCachePolicyProvider with DI as an IOutputCachePolicyProvider and then use that in the middleware probably here.

@onurkanbakirci Are you still interested in following up on this feedback and trying to merge this PR? Do you need any additional help from us to point you in the right direction?

If not, we'll have to close it until you or someone else can make the requested improvements.

[dotnet-policy-service]

Hi @onurkanbakirci.
It seems you haven't touched this PR for the last two weeks. To avoid accumulating old PRs, we're marking it as stale. As a result, it will be closed if no further activity occurs within 4 days of this comment. You can learn more about our Issue Management Policies here.

[Arnab-Developer]

@onurkanbakirci Are you still interested in following up on this feedback and trying to merge this PR? Do you need any additional help from us to point you in the right direction?

If not, we'll have to close it until you or someone else can make the requested improvements.

@halter73 can I complete the missing parts of this PR and send a new PR from my fork?