HybridCache: reflect API merge into runtime - preview 7 backport #56946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgravell
added
the
feature-caching
dotnet-issue-labeler
bot
added
the
area-infrastructure
|
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
mitchdenny
approved these changes
Jul 23, 2024
captainsafia
approved these changes
Jul 23, 2024
wtgodbe
approved these changes
Jul 23, 2024
|
Should cherry-pick this into #56962 |
mgravell
changed the base branch from
release/9.0-preview7
to
darc-release/9.0-preview7-c259b2cd-b00e-4c3b-b2fb-6b98cf9f247a
|
@wtgodbe lets see if this works... changed target/base from |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
tested locally - needed to add back a few more "unshipped" (I guess I got carried away with the del) - should build now |
|
@wtgodbe definitely improving - https://github.com/dotnet/aspnetcore/pull/56946/checks?check_run_id=27868375271 still has some unrelated (I hope!) errors in Something is up with "Linux Musl ARM" and "macOS arm64" like they haven't got the updated bits - taking a peek, but EOD here |
wtgodbe
merged commit f12be00
into
darc-release/9.0-preview7-c259b2cd-b00e-4c3b-b2fb-6b98cf9f247a
7 of 27 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HybridCache: reflect API merge into runtime
In runtime 103103, the proposed HybridCache API was moved from a placeholder in aspnetcore into runtime (which owns the Microsoft.Extensions.Caching.Abstractions library). This means that the original API in aspnetcore is now duplicated and redundant. Additionally, runtime requested some minor last-minute API changes (mainly: prefer
cancellationTokenovertokennaming, and preferIEnumerable<string>overIReadOnlyCollection<string>for tags parameter)This PR reflects this merge - removing the duplicated APIs, and fixing the changes impacted by the API delta.
Since 103103 was merged immediately before the preview 7 snap, this will need applying both in
mainandrelease/9.0-preview7after the runtime deps are updated (this is therelease/9.0-preview7version). Until runtime is built and the deps are updated, aspnetcore may be unbuildable.Cross-reference: #56945 (
main)