Add support for CreateSchemaReferenceId option #56753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-web-frameworks
3 tasks
Co-authored-by: Martin Costello <martin@martincostello.com>
BrennanConroy
approved these changes
Jul 12, 2024
| schema.ApplyPrimitiveTypesAndFormats(context); | ||
| schema.ApplySchemaReferenceId(context); | ||
| schema.ApplyPolymorphismOptions(context); | ||
| var createSchemaReferenceId = optionsMonitor.Get(documentName).CreateSchemaReferenceId; |
There was a problem hiding this comment.
_openApiOptions is an instance field so we can't use it in the initializer for _confguration. I could switch to standard constructors instead of primary constructors and initialize everything there but.... 😅 🤪
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #56305.
This PR adds support for a
CreateSchemaReferenceIdproperty in theOpenApiOptionsto support customizing how reference IDs are generated for schemas assocaited with a given type. Because of the behavior of the reference ID implementation, this function also serves as a mechanism for being able to determine whther or not a schema should be inline or referenced:CreateSchemaReferenceIddelegate that returnsnullfor a given type will mean that schemas associated with that type are always inlineCreateSchemaReferenceIddelegate that returns a value for a given type will mean that schemas assocaited with that type will always be referencedChanges in this PR include:
CreateSchemaReferenceIdproperty to options object andCreateDefaultSchemaReferenceIdstatic to provide users with access to the default implementationCreateSchemaReferenceIdfrom options in all codepaths where it is currently relevant