[release/6.0] Switch to dynamic cert gen for tests #55811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-infrastructure
| @@ -24,7 +24,7 @@ | |||
|
|
|||
| namespace Microsoft.AspNetCore.Authentication.Certificate.Test | |||
| { | |||
| public class ClientCertificateAuthenticationTests | |||
| public class ClientCertificateAuthenticationTests : LoggedTest | |||
wtgodbe
approved these changes
May 20, 2024
wtgodbe
added
the
tell-mode
|
Marking as |
|
@dotnet/aspnet-build Can someone merge this? |
Patch merge windows apply to tell-mode changes too. You'll need to wait for the next window. |
dotnet-policy-service
bot
added
the
pending-ci-rerun
wtgodbe
removed
the
pending-ci-rerun
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of our test certs in release/6.0's
src/Shared/test/Certificates/directory expired on Friday, May 17th. This PR cherry-picks #39685 to dynamically generate these certs so they don't expire again. This should unblock our dependency update at #55798.