Update to new interceptable location APIs #55285
Conversation
ghost
added
the
area-minimal
|
@dotnet/source-build-internal Any guidance on the source build issues here? |
|
I believe these two new prebuilts should be added to the SourceBuildPrebuiltBaseline as allowed prebuilts. These won't be prebuilts in the product source-build because the live Rolsyn version will get picked up because the dependency is declared in the Version.Details.xml file. |
captainsafia
requested review from
BrennanConroy,
halter73,
a team and
wtgodbe
as code owners
| public IInvocationOperation Operation { get; } | ||
|
|
||
| public override bool Equals(object o) => | ||
| o is Endpoint other && Location == other.Location && SignatureEquals(this, other); | ||
| o is Endpoint other && InterceptableLocation == other.InterceptableLocation && SignatureEquals(this, other); |
There was a problem hiding this comment.
I don't think we implemented operator == on these. That might be a bug on our side. I'll have to follow up.
There was a problem hiding this comment.
An explicit == implementation would be nice. I assume this does implement equality checks correctly though given that it does the correct things in our cache invalidation tests for incremental generators.
|
@dotnet/aspnet-build Can I get help merging this? The macOS build is successful on AzDo but there appears to be an issue with the GH status check. |
Addresses #55152