Include a warning about port spoofing in xml#54971
Closed
bseptember wants to merge 7 commits intodotnet:mainfrom
Closed
Include a warning about port spoofing in xml#54971bseptember wants to merge 7 commits intodotnet:mainfrom
bseptember wants to merge 7 commits intodotnet:mainfrom
Conversation
ghost
added
the
area-networking
dotnet-policy-service
bot
added
the
community-contribution
src/Http/Routing/src/Builder/RoutingEndpointConventionBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Martin Costello <martin@martincostello.com>
Member
|
Seems like something @captainsafia would have thoughts on. Also, do we know why those crefs aren't binding? |
captainsafia
reviewed
Apr 5, 2024
Contributor
captainsafia
left a comment
captainsafia
left a comment
There was a problem hiding this comment.
Also tagging @Rick-Anderson and @tdykstra for doc review.
src/Http/Routing/src/Builder/RoutingEndpointConventionBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/Http/Routing/src/Builder/RoutingEndpointConventionBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
tdykstra
reviewed
Apr 6, 2024
src/Http/Routing/src/Builder/RoutingEndpointConventionBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/Http/Routing/src/Builder/RoutingEndpointConventionBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
captainsafia
approved these changes
Apr 8, 2024
Contributor
|
@dotnet/aspnet-build CI status seems off on this PR. Can I get help merging since it's just a docs change? |
halter73
requested changes
Apr 8, 2024
src/Http/Routing/src/Builder/RoutingEndpointConventionBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Stephen Halter <halter73@gmail.com>
halter73
approved these changes
Apr 12, 2024
Rick-Anderson
suggested changes
Apr 12, 2024
src/Http/Routing/src/Builder/RoutingEndpointConventionBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
…ds against host and port spoofing presents the information in a more continuous narrative Co-authored-by: Rick Anderson <3605364+Rick-Anderson@users.noreply.github.com>
dotnet-policy-service
bot
added
the
pending-ci-rerun
Contributor
|
@bseptember It looks like there is an XML syntax issue on the PR. Would you be able to fix it? Otherwise, I can make a modification in this branch. |
| /// </description></item> | ||
| /// </list> | ||
| /// </remarks> | ||
| /// </remarks> |
Contributor
There was a problem hiding this comment.
Suggested change
| /// </remarks> |
Rick-Anderson
approved these changes
Jun 28, 2024
Contributor
|
Closing this PR, as we haven't received a response from the author for quite a while. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include a warning about port spoofing in xml
Summary of the changes
Added remark which describes the warning as per https://learn.microsoft.com/en-us/aspnet/core/host-and-deploy/health-checks?view=aspnetcore-7.0#require-host
Description
Update API remarks for RoutingEndpointConventionBuilderExtensions.RequireHost to warn about host spoofing
Fixes #48818 (documentation changed)