Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unquarantine CanLaunchPhotinoWebViewAndClickButton #54339

Conversation

SteveSandersonMS
Copy link
Member

@SteveSandersonMS SteveSandersonMS commented Mar 4, 2024

Originally I was just trying to capture a failure log, but it's been passing every time. There are no failures on record in the last 30 days.

As such I think our only way forwards is to unquarantine, and if it does fail again, then we'll have a log to work from.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-blazor Includes: Blazor, Razor Components label Mar 4, 2024
@SteveSandersonMS SteveSandersonMS added the * NO MERGE * Do not merge this PR as long as this label is present. label Mar 4, 2024
@SteveSandersonMS SteveSandersonMS changed the title Experimentally unquarantine CanLaunchPhotinoWebViewAndClickButton Unquarantine CanLaunchPhotinoWebViewAndClickButton Mar 6, 2024
@SteveSandersonMS SteveSandersonMS marked this pull request as ready for review March 6, 2024 10:48
@SteveSandersonMS SteveSandersonMS requested a review from a team as a code owner March 6, 2024 10:48
@SteveSandersonMS SteveSandersonMS removed the * NO MERGE * Do not merge this PR as long as this label is present. label Mar 6, 2024
@SteveSandersonMS SteveSandersonMS self-assigned this Mar 6, 2024
@javiercn
Copy link
Member

javiercn commented Mar 6, 2024

@SteveSandersonMS if the test can run multiple times without issue, one thing to try is the "run until failure" feature in VS. Maybe kicking it off in a devbox to see if it reproes that way. Either way there's good enough info to unquarantine it at that point

@SteveSandersonMS SteveSandersonMS merged commit 2541220 into main Mar 6, 2024
26 checks passed
@SteveSandersonMS SteveSandersonMS deleted the stevesa/unquarantine-CanLaunchPhotinoWebViewAndClickButton branch March 6, 2024 17:04
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview3 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants