Skip to content

Update Locker GitHub action to only lock issues (not PRs)#53225

Merged
wtgodbe merged 2 commits into
dotnet:mainfrom
jeffhandley:jeffhandley/locker-action
Jan 9, 2024
Merged

Update Locker GitHub action to only lock issues (not PRs)#53225
wtgodbe merged 2 commits into
dotnet:mainfrom
jeffhandley:jeffhandley/locker-action

Conversation

@jeffhandley

Copy link
Copy Markdown
Member

Update Locker GitHub action to only lock issues (not PRs)

Update the Locker workflow to use microsoft/vscode-github-triage-actions@0e46b66 and configure the action to only lock issues.

Description

This is follow-up to #52651. In that PR, we adopted the Locker action but then found that it was locking both issues and PRs; we only want to lock issues. microsoft/vscode-github-triage-actions#197 was merged, and we can now configure the action to only lock issues.

@jeffhandley jeffhandley requested review from a team and wtgodbe as code owners January 8, 2024 23:48
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 8, 2024
@ghost

ghost commented Jan 8, 2024

Copy link
Copy Markdown

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@wtgodbe wtgodbe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The test failures are an unrelated known issue, I can merge around them once CI finishes. Is there a way to do a dry run?

@jeffhandley

Copy link
Copy Markdown
Member Author

I just conducted a dry run on my fork, and it ran successfully. There was of course no work for it to do though. https://github.com/jeffhandley/aspnetcore/actions/runs/7465452749/job/20314631341

Once we merge this, @wtgodbe, we'll run it interactively through the Actions UI, and we should expect it will fail to process all issues/PRs until it catches up.

@wtgodbe wtgodbe enabled auto-merge (squash) January 9, 2024 19:28
@wtgodbe wtgodbe merged commit ae4c192 into dotnet:main Jan 9, 2024
@ghost ghost added this to the 9.0-preview1 milestone Jan 9, 2024
@jeffhandley jeffhandley deleted the jeffhandley/locker-action branch January 9, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants