Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarantine HelixPlatform_QuicListenerIsSupported #52624

Merged
merged 3 commits into from
Dec 8, 2023
Merged

Quarantine HelixPlatform_QuicListenerIsSupported #52624

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb15fba
Quarantine HelixPlatform_QuicListenerIsSupported
SteveSandersonMS Dec 7, 2023
86bc0fd
Scope down the quarantine
SteveSandersonMS Dec 7, 2023
5d54079
Update WebHostTests.cs
JamesNK Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Servers/Kestrel/Transport.Quic/test/WebHostTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,16 @@ public class WebHostTests : LoggedTest
// This test isn't conditional on QuicListener.IsSupported. Instead, it verifies that HTTP/3 runs on expected CI platforms:
// 1. Windows 11 or later.
// 2. Linux with libmsquic package installed.
//
// The main build and PR builds run Helix tests run on different OSes. Be cautious when editing OSes skipped on this test
// as the test might pass in the PR build but cause the main build to fail once merged.
[ConditionalFact]
[SkipNonHelix]
[SkipOnAlpine("https://github.com/dotnet/aspnetcore/issues/46537")]
[SkipOnMariner("https://github.com/dotnet/aspnetcore/issues/46537")]
[OSSkipCondition(OperatingSystems.MacOSX, SkipReason = "HTTP/3 isn't supported on MacOS.")]
[MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win11_21H2)]
[SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/52623", Queues = HelixConstants.DebianArm64)]
public void HelixPlatform_QuicListenerIsSupported()
{
Assert.True(QuicListener.IsSupported, "QuicListener.IsSupported should be true.");
Expand Down
Loading