Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Skip failing template tests on Win11-arm64 #51311

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Oct 11, 2023

Fixes #49061

These tests fail on our win11-arm64 test run because the bits were built on Linux - therefore runtime throws a PlatformNotSupportedException. We no longer run tests on win10-arm64, so this PR updates the tests to run on win11-arm64 instead. In 7.0 and above, we build everything on Windows for the helix-matrix, so we don't see the issue there.

Helix-matrix run with this change: https://dev.azure.com/dnceng-public/public/_build/results?buildId=435150&view=results

@wtgodbe wtgodbe requested review from mkArtakMSFT and a team October 11, 2023 23:40
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Oct 11, 2023
@wtgodbe wtgodbe changed the title Skip failing template tests on Win11-arm64 [release/6.0] Skip failing template tests on Win11-arm64 Oct 11, 2023
@ghost ghost added this to the 6.0.x milestone Oct 11, 2023
@ghost
Copy link

ghost commented Oct 11, 2023

Hi @wtgodbe. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@ghost
Copy link

ghost commented Oct 19, 2023

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Oct 19, 2023
@wtgodbe
Copy link
Member Author

wtgodbe commented Nov 8, 2023

/azp run

@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Nov 8, 2023
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@wtgodbe wtgodbe merged commit 261b9ac into release/6.0 Nov 9, 2023
23 of 26 checks passed
@wtgodbe wtgodbe deleted the wtgodbe/FixSkips6.0 branch November 9, 2023 01:17
@ghost ghost modified the milestones: 6.0.x, 6.0.24 Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant