-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Update SDK #51240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SDK #51240
Conversation
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
This comment was marked as resolved.
This comment was marked as resolved.
It's because the SDK being used for the build still points to the old 8.0 P7 version in its BundledVersions.props file causing this version to be loaded for net8.0. For now, this can be added to https://github.com/dotnet/aspnetcore/blob/main/eng/SourceBuildPrebuiltBaseline.xml as an allowed prebuilt. |
Thank you @mthalman for the suggestion. |
@MackinnonBuck @javiercn @mkArtakMSFT - It looks like the test failures are in the Components E2E tests. Can someone from the Blazor team take a look? |
@SteveSandersonMS @halter73 - any chance one of you could look at the failing tests here? |
It looks like at least part of the problem is that interactively-rendered |
Alright, hopefully this works :) |
@MackinnonBuck I was expecting changes in |
@SteveSandersonMS I believe that's correct. I just opted to cherry-pick one of your commits from #51059 in order to unblock this SDK update without waiting for the next merge PR. However, I do see that there hasn't been an active @wtgodbe, do you know why this is the case? |
I disabled automatic merges from 8.0 to main after RC2 locked down, I sent a couple emails to the team about it. I'm doing periodic mop-up merges between now and RTM to get any changes that got missed. |
No description provided.