Skip to content

Update SDK #51240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 20, 2023
Merged

Update SDK #51240

merged 7 commits into from
Oct 20, 2023

Conversation

MackinnonBuck
Copy link
Member

No description provided.

@MackinnonBuck MackinnonBuck added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Oct 9, 2023
@MackinnonBuck MackinnonBuck requested review from wtgodbe and a team as code owners October 9, 2023 19:16
@ghost
Copy link

ghost commented Oct 9, 2023

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@MackinnonBuck MackinnonBuck requested review from captainsafia and a team as code owners October 10, 2023 20:20
@RussKie RussKie enabled auto-merge (squash) October 12, 2023 05:28
@MackinnonBuck MackinnonBuck requested a review from a team as a code owner October 12, 2023 05:44
@RussKie

This comment was marked as resolved.

@mthalman
Copy link
Member

It's because the SDK being used for the build still points to the old 8.0 P7 version in its BundledVersions.props file causing this version to be loaded for net8.0. For now, this can be added to https://github.com/dotnet/aspnetcore/blob/main/eng/SourceBuildPrebuiltBaseline.xml as an allowed prebuilt.

@RussKie
Copy link
Contributor

RussKie commented Oct 12, 2023

Thank you @mthalman for the suggestion.

@eerhardt
Copy link
Member

@MackinnonBuck @javiercn @mkArtakMSFT - It looks like the test failures are in the Components E2E tests. Can someone from the Blazor team take a look?

@eerhardt
Copy link
Member

@SteveSandersonMS @halter73 - any chance one of you could look at the failing tests here?

@MackinnonBuck
Copy link
Member Author

It looks like at least part of the problem is that interactively-rendered <script> elements no longer execute. Some of our tests were depending on that working. I haven't been able to track down the reason just yet.

@MackinnonBuck MackinnonBuck requested a review from a team as a code owner October 20, 2023 00:16
@MackinnonBuck
Copy link
Member Author

Alright, hopefully this works :)

@RussKie RussKie merged commit f640c1a into main Oct 20, 2023
@RussKie RussKie deleted the mbuck/sdk-update branch October 20, 2023 02:03
@ghost ghost added this to the 9.0-preview1 milestone Oct 20, 2023
@SteveSandersonMS
Copy link
Member

@MackinnonBuck I was expecting changes in release/8.0 to flow into main automatically. Do you know if that's incorrect? If so there are a lot of 8.0 changes that need to get ported to main.

@MackinnonBuck
Copy link
Member Author

MackinnonBuck commented Oct 23, 2023

I was expecting changes in release/8.0 to flow into main automatically

@SteveSandersonMS I believe that's correct. I just opted to cherry-pick one of your commits from #51059 in order to unblock this SDK update without waiting for the next merge PR. However, I do see that there hasn't been an active release/8.0 => main merge PR in two weeks...

@wtgodbe, do you know why this is the case?

@dotnet dotnet deleted a comment Oct 23, 2023
@wtgodbe
Copy link
Member

wtgodbe commented Oct 23, 2023

I disabled automatic merges from 8.0 to main after RC2 locked down, I sent a couple emails to the team about it. I'm doing periodic mop-up merges between now and RTM to get any changes that got missed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants