-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Blazor web csharp template #51030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Blazor web csharp template #51030
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e5efd62
Better a11y
EdCharbeneau f70b357
Merged with current main branch
EdCharbeneau 44f2a89
Updated to include Auth nav
EdCharbeneau 56f4d3d
Refactored CSS with nesting https://developer.mozilla.org/en-US/docs/…
EdCharbeneau 216f55c
Updated template localization strings.
EdCharbeneau e4f9ca4
Fixed incorrect aria attributes on NavBar.
EdCharbeneau File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
...ProjectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Layout/Header.razor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| <header class="navbar navbar-expand flex-wrap justify-content-between bg-body-tertiary p-0 shadow-sm"> | ||
| <a class="navbar-brand ps-3" href="">BlazorWeb-CSharp</a> | ||
| <ul class="navbar-nav"> | ||
| <li class="nav-item"> | ||
| <a class="nav-link" href="https://learn.microsoft.com/aspnet/core/" target="_blank">About</a> | ||
| </li> | ||
| </ul> | ||
| </header> |
18 changes: 18 additions & 0 deletions
18
...ectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Layout/Header.razor.css
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| .navbar-brand { | ||
| height: 3.5rem; | ||
| font-size: 1.1rem; | ||
| width: 100%; | ||
| display: flex; | ||
| align-items: center; | ||
| margin: 0; | ||
| background-color: var(--bl-blazor-brand-color1); | ||
|
|
||
| &, &:hover, &:visited { | ||
| color: var(--bl-blazor-brand-contrast-color); | ||
| } | ||
|
|
||
| @media (width >= 641px) { | ||
| width: 250px; | ||
| margin-right: 1rem; | ||
| } | ||
| } |
22 changes: 10 additions & 12 deletions
22
...ectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Layout/MainLayout.razor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe those translations will happen automatically as a separate PR. So you should exclude those changes from your PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per the readme, it looked like it was required. Maybe this needs some clarification?
https://github.com/dotnet/aspnetcore/blob/main/src/ProjectTemplates/README.md#submitting-pull-requests
Per @SteveSandersonMS if the PR is still wanted, I will go back and remove the translation files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I wouldn't worry about such details since it would be more useful to use this as a starting point or set of requirements for the bigger redesign effort for .NET 9.
I see that #50927 is already tracked in the ".NET 9 planning" milestone so will get considered there, and perhaps could serve as the tracking issue for the proposed redesign. Since that issue already links to this PR, we'll be able to find our way back here (even if this is closed) to see the description and implementation at the right time.