Skip to content

Bug hash routing same page with params or query #48994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 7, 2023
Merged

Bug hash routing same page with params or query #48994

merged 5 commits into from
Jul 7, 2023

Conversation

@surayya-MS
Copy link
Member

@surayya-MS surayya-MS commented Jun 23, 2023 •
edited
Loading

Fix scrolling when navigating to same url with params (or query) and hash

Fixes #48993

@surayya-MS surayya-MS requested a review from a team as a code owner June 23, 2023 16:24
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Jun 23, 2023
@surayya-MS surayya-MS changed the title Bug hash routing same page with query Bug hash routing same page with params or query Jun 29, 2023
@ghost
Copy link

ghost commented Jul 7, 2023

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no breaking changes are introduced, please leave an /azp run comment here to rerun the CI pipeline and confirm success before merging the change.

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Jul 7, 2023
SteveSandersonMS
SteveSandersonMS approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@SteveSandersonMS SteveSandersonMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

@surayya-MS surayya-MS merged commit 2b9bec6 into dotnet:main Jul 7, 2023
@surayya-MS surayya-MS deleted the bugHashRoutingSamePageWithQuery branch July 7, 2023 15:06
@ghost ghost added this to the 8.0-preview7 milestone Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveSandersonMS SteveSandersonMS SteveSandersonMS approved these changes

Assignees

No one assigned

Labels

area-blazor Includes: Blazor, Razor Components pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun

Projects

None yet

Milestone

8.0-preview7

Development

Successfully merging this pull request may close these issues.

Scroll doesn't work when calling NavigationManager.NavigateTo() same url with query and hash

2 participants

@surayya-MS @SteveSandersonMS