Support IHttpSysRequestInfoFeature and IHttpSysRequestTimingFeature in IIS in proc server #48663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NGloreous
requested review from
Tratcher,
halter73,
BrennanConroy,
JamesNK and
mgravell
as code owners
ghost
added
area-runtime
community-contribution
|
Thanks for your PR, @NGloreous. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Tratcher
approved these changes
Jun 7, 2023
auto-merge was automatically disabled
June 7, 2023 21:15
Head branch was pushed to by a user without write access
10 tasks
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support IHttpSysRequestInfoFeature and IHttpSysRequestTimingFeature in IIS in proc server
IHttpSysRequestInfoFeature and IHttpSysRequestTimingFeature features are currently only supported in the Http.Sys server implementation. This change moves the implementation of these feature down to the shared layer and adds these features to the IIS in proc server.
Description
Access the detailed Http.sys request info is useful to applications regardless of where they are hosted (Http.sys standalone or IIS in proc). Currently this information is only exposed in the Http.sys standalone sever. This change updates the IIS in proc server to take a dependency on Microsoft.AspNetCore.Server.HttpSys.dll so it has access to the existing feature interfaces and moves the implementation of these interfaces into NativeRequestContext.cs which is shared between the two servers. Future changes to address adding APIs for the Http.sys information (tracked by #35012) can easily add support for both servers at the same time.
Fixes #3842