[release/8.0-preview5] Ensure ComponentState is always disposed #48410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
mkArtakMSFT
added
the
Servicing-consider
|
Hi @github-actions[bot]. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
mkArtakMSFT
added
Servicing-approved
|
Hi @github-actions[bot]. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed. |
mkArtakMSFT
approved these changes
May 24, 2023
mkArtakMSFT
approved these changes
May 24, 2023
ghost
added
the
area-infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #48406 to release/8.0-preview5
/cc @SteveSandersonMS
Ensure ComponentState is always disposed
Updates the component disposal logic to ensure that
ComponentStateis always disposed, and henceArrayBuilderinstances are always disposed, and hence we always return the underlying buffers to the pool.Description
Without this, the pooling of
ArrayBuilder-held arrays becomes ineffective because the pools become full, and then the behavior switches over to transient instances, reverting to regular GC behavior.Fixes #48411
Customer Impact
This fix will significantly reduce GC pressure because the
RenderTreeFrame[]instances are large. In one test, after 20 requests, we had allocated 57MB ofRenderTreeFrame[]instances. This is not a leak, but it does cause the GC to work harder because more memory is being allocated quickly and hence collections must occur more frequently.The fix causes pooling to work correctly so that even though the same amount of
RenderTreeFrame[]storage is needed, it will be able to reuse the same storage across requests so in most cases it won't trigger any GC pressure.Regression?
The issue has been present since 2019.
Risk
Low because this is a 8.0 preview release, we have tests, and several people have reviewed this code.
Verification
Packaging changes reviewed?