Make EndpointHtmlRenderer track the HttpContext #48088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a really minor detail but I'm splitting it out from my larger PR about render modes just to try to keep the bigger one more practical to review clearly.
EndpointHtmlRenderer will need access to the HttpContext when writing out the HTML content to the response writer because this is used as part of generating the Server/WebAssembly markers for interactive components (e.g., to track per-response marker sequence numbers and to use DataProtection for formatting the server component markers).
Currently, it doesn't have access to the HttpContext at the right time, so this PR makes it treat HttpContext as an instance field, rather than something that just lives transiently in the call stack. This is perfectly fine to do because EndpointHtmlRender is scoped to the request anyway.