-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure DataProtection can be used in trimmed apps. #48082
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More of a question than a blocking issue. Seems we are copying a type definition that already exists in code analysis?
...rotection/DataProtection/test/Microsoft.AspNetCore.DataProtection.TrimmingTests/Constants.cs
Show resolved
Hide resolved
Add EncryptedXmlDecryptor test. Add credscan suppression
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build bits seem reasonable
Anyone have any feedback about the DataProtection pieces? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have limited knowledge of this code, but the change seems low-risk to me. Nits below.
src/DataProtection/DataProtection/src/XmlEncryption/CertificateXmlEncryptor.cs
Outdated
Show resolved
Hide resolved
src/DataProtection/DataProtection/src/XmlEncryption/CertificateXmlEncryptor.cs
Show resolved
Hide resolved
src/DataProtection/DataProtection/src/XmlEncryption/EncryptedXmlDecryptor.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the offline explanation!
Nice! Does this mean we can move authentication/authorization to the AOT supported column? |
Some things still don't work. For example, the JWT bearer handler depends on System.IdentityModel.Tokens.Jwt, which is not AOT compatible. For the other authentication modes, are there other 3rd party dependencies? Or are they all contained in this repo? |
Hi @eerhardt. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
Fix #47695