Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure DataProtection can be used in trimmed apps. #48082

Merged
merged 7 commits into from
May 13, 2023

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented May 5, 2023

  • Add a DynamicDependency to ensure Aes decryption works in EncryptedXmlDecryptor
  • Suppress the warnings from EncryptedXml
  • Add trimming tests to ensure these scenarios work correctly.
  • Remove the RequiresUnreferencedCode attribute on AddAuthentication, since this is the only thing in that method that has warnings.

Fix #47695

@eerhardt eerhardt requested review from halter73 and JamesNK May 5, 2023 00:37
@eerhardt eerhardt requested review from Tratcher, a team and wtgodbe as code owners May 5, 2023 00:37
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-dataprotection Includes: DataProtection label May 5, 2023
Copy link
Member

@mitchdenny mitchdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More of a question than a blocking issue. Seems we are copying a type definition that already exists in code analysis?

Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build bits seem reasonable

@eerhardt
Copy link
Member Author

Anyone have any feedback about the DataProtection pieces?

Copy link
Member

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have limited knowledge of this code, but the change seems low-risk to me. Nits below.

Copy link
Member

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the offline explanation!

@eerhardt eerhardt enabled auto-merge (squash) May 12, 2023 23:35
@eerhardt eerhardt merged commit 3ff3207 into dotnet:main May 13, 2023
@ghost ghost added this to the 8.0-preview5 milestone May 13, 2023
@JamesNK
Copy link
Member

JamesNK commented May 13, 2023

Nice!

Does this mean we can move authentication/authorization to the AOT supported column?

@eerhardt eerhardt deleted the DataProtection branch May 15, 2023 02:06
@eerhardt
Copy link
Member Author

Does this mean we can move authentication/authorization to the AOT supported column?

Some things still don't work. For example, the JWT bearer handler depends on System.IdentityModel.Tokens.Jwt, which is not AOT compatible.

For the other authentication modes, are there other 3rd party dependencies? Or are they all contained in this repo?

@ghost
Copy link

ghost commented May 15, 2023

Hi @eerhardt. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-dataprotection Includes: DataProtection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Respond to IL2026 warnings in DataProtection originating from EncryptedXml
6 participants